Skip to content

Add S3 SSE KMS key and bucket key encryption - #28601

Closed
juliusknorr wants to merge 1 commit into
masterfrom
enh/s3-sse-kms
Closed

Add S3 SSE KMS key and bucket key encryption#28601
juliusknorr wants to merge 1 commit into
masterfrom
enh/s3-sse-kms

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Aug 26, 2021

Copy link
Copy Markdown
Member

Originally proposed by @tsdicloud this is the rebased version of #26899 with pulling the changes from https://github.com/nextmcloud/server/compare/master..s3fragment without the already merged parts from #27877

Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
@juliusknorrjuliusknorr added 3. to review Waiting for reviews enhancement feature: object storage pending documentation This pull request needs an associated documentation update labels Aug 27, 2021
@juliusknorrjuliusknorr added this to the Nextcloud 23 milestone Aug 27, 2021
@juliusknorrjuliusknorr changed the title Add S3 SSE KMS key and bucketked encryptionAdd S3 SSE KMS key and bucket key encryptionAug 27, 2021
@skjnldsvskjnldsv mentioned this pull request Oct 13, 2021
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

🏓 for review

'Key' => $urn,
'Range' => 'bytes=' . $range,
]);
] + $this->getSseKmsGetParameters());

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SseKmsPutParameters is placed under a config property, SseKmsGetParameters is not, is this right?

Comment threadlib/private/Files/ObjectStore/S3ConnectionTrait.php
@skjnldsvskjnldsv mentioned this pull request Mar 24, 2022
@blizzzblizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzzblizzz modified the milestones: Nextcloud 24, Nextcloud 25Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
@blizzzblizzz mentioned this pull request Sep 6, 2022
@blizzzblizzz mentioned this pull request Sep 9, 2022
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Closing this for now as there is no current demand. This can be picked up to finish anytime of course.

@skjnldsvskjnldsv removed this from the Nextcloud 27 milestone Mar 2, 2023
@juliusknorrjuliusknorr removed the pending documentation This pull request needs an associated documentation update label Jun 8, 2023
@skjnldsv
skjnldsv deleted the enh/s3-sse-kms branch March 14, 2024 07:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr@artonge@blizzz@skjnldsv@tsdicloud