Skip to content

Nmc 430-harmonizing of sharing permissions step 1 - #28635

Closed
TSI-yogeshshejwadkar wants to merge 2 commits into
nextcloud:masterfrom
nextmcloud:NMC-430
Closed

Nmc 430-harmonizing of sharing permissions step 1#28635
TSI-yogeshshejwadkar wants to merge 2 commits into
nextcloud:masterfrom
nextmcloud:NMC-430

Conversation

@TSI-yogeshshejwadkar

@TSI-yogeshshejwadkarTSI-yogeshshejwadkar commented Aug 29, 2021

Copy link
Copy Markdown

Folders
Internal Share:
we removed the checkboxes "Allow editing", "Allow creating" and "Allow deleting"
we added a radio button group containing the options: "Read only" (Nur Lesen), "Allow upload and editing" (Hochladen & Bearbeiten)
External Share: no changes
Link Share: no changes

Files
Internal Share:
we removed the checkbox "Allow editing"
we added a radio button group containing the options: "Read only" (Nur lesen), "Editing" (Bearbeiten)
External Share:
we removed the checkbox "Allow editing"
we added a radio button group containing the options: "Read only" (Nur lesen), "Editing" (Bearbeiten)
Link Share:
we removed the checkbox "Allow editing"
we added a radio button group containing the options: "Read only" (Nur lesen), "Editing" (Bearbeiten)

Signed-off-by: Yogesh Shejwadkar yogesh.shejwadkar@t-systems.com

@szaimenszaimen added 3. to review Waiting for reviews enhancement feature: sharing design Design, UI, UX, etc. labels Aug 29, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Aug 29, 2021
@kesselb

Copy link
Copy Markdown
Contributor

Hey 👋

it looks like a mistake, to me, that changes related to S3 and encryption are part of this pull request.

@juliusknorr

Copy link
Copy Markdown
Member

In addition the commit is missing a Signed-of-by message as described in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work

@juliusknorr

This comment has been minimized.

@nextcloudnextcloud deleted a comment from Salvador1313Aug 30, 2021
@nextcloudnextcloud deleted a comment from Salvador1313Aug 30, 2021
@TSI-yogeshshejwadkar
TSI-yogeshshejwadkarforce-pushed the NMC-430 branch 2 times, most recently from ac9daad to d22fac4CompareAugust 30, 2021 12:20
@TSI-yogeshshejwadkar

Copy link
Copy Markdown
Author

Hey

it looks like a mistake, to me, that changes related to S3 and encryption are part of this pull request.

Removed the extra commits

@TSI-yogeshshejwadkar

Copy link
Copy Markdown
Author

In addition the commit is missing a Signed-of-by message as described in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work

Added the message

@szaimen

Copy link
Copy Markdown
Contributor

/compile amend /

@kesselb

kesselb commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Some screenshots for easier review:

BeforeAfter
folderScreenshot from 2021-08-30 22-09-19Screenshot from 2021-08-30 22-07-54
file
internal
Screenshot from 2021-08-30 22-17-42Screenshot from 2021-08-30 22-23-47
file
link
Screenshot from 2021-08-30 22-17-56Screenshot from 2021-08-30 22-24-03

@kesselb

Copy link
Copy Markdown
Contributor

Well done 👍

image

To fix the CI: Build the changes locally (make build-js-production) and commit the above files.

@AndyScherzinger

Copy link
Copy Markdown
Member

@juliushaertl@skjnldsv is this really v23 or does this need to be backported to v22, sames question for #28636 of course

@TSI-yogeshshejwadkar

Copy link
Copy Markdown
Author

Well done

image

To fix the CI: Build the changes locally (make build-js-production) and commit the above files.

added the requested file. Thanks :)

@blizzzblizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzzblizzz modified the milestones: Nextcloud 24, Nextcloud 25Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
@blizzzblizzz mentioned this pull request Mar 7, 2023
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
This was referenced May 3, 2023
@juliusknorr
juliusknorr removed their request for review May 15, 2023 18:59
@tsdicloud
tsdicloud deleted the NMC-430 branch July 13, 2023 11:09
@AndyScherzinger

Copy link
Copy Markdown
Member

Superseeded by #26691

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.enhancementfeature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@TSI-yogeshshejwadkar@kesselb@juliusknorr@szaimen@AndyScherzinger@jancborchardt@artonge@blizzz@skjnldsv