Skip to content

Update config.sample.php - #28637

Merged
kesselb merged 2 commits into
nextcloud:masterfrom
JensTimmerman:master
Oct 13, 2021
Merged

Update config.sample.php#28637
kesselb merged 2 commits into
nextcloud:masterfrom
JensTimmerman:master

Conversation

@JensTimmerman

@JensTimmermanJensTimmerman commented Aug 29, 2021

Copy link
Copy Markdown

fixes#21674

mteam88
mteam88 approved these changes Aug 29, 2021
View reviewed changes

@mteam88mteam88 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem to help clarity.

@szaimenszaimen added the 3. to review Waiting for reviews label Aug 31, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Aug 31, 2021
szaimen
szaimen approved these changes Aug 31, 2021
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaIng

MichaIng commented Sep 3, 2021•
edited
Loading

Copy link
Copy Markdown
Member

/run/postgresql/ is definitely correct on Debian and Ubuntu 👍. The trailing slash can be omitted, though: /run/postgresql

@JensTimmerman
Can you squash and signoff the commits, to satisfy DCO? At least me cannot merge otherwise.

@mteam88

mteam88 commented Sep 3, 2021

Copy link
Copy Markdown

@JensTimmerman
Please fix DCO.

@szaimenszaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 13, 2021
@skjnldsvskjnldsv mentioned this pull request Oct 13, 2021
Merged
@kesselb
kesselb merged commit b7ee885 into nextcloud:masterOct 13, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaIngMichaIngMichaIng approved these changes
@szaimenszaimenszaimen approved these changes
+1 more reviewer
@mteam88mteam88mteam88 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2. developingWork in progress

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

occ maintenance:install fails when Postgres is socket-only

5 participants

@JensTimmerman@MichaIng@mteam88@szaimen@kesselb