Uh oh!
There was an error while loading. Please reload this page.
NMC-552 Move filename/size out of the download button - #28643
Conversation
juliusknorr
commented
Aug 30, 2021
Please do not include the change in the 3rdparty submodule in here. In addition the commit is missing a Signed-of-by message as described in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
artonge
commented
Aug 31, 2021
I would also add some space above the .directDownload#downloadFile {
... margin-top: 16px;
} |
085235c to
773898dCompare
artonge
left a comment
There was a problem hiding this comment.
Need DCO, else looks good :)
git rebase HEAD~6 --signoff
git push --force-with-lease origin NMC-552Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
943ca47 to
bc6b496CompareThanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Pytal
commented
Sep 2, 2021
/backport to stable22 |
Guest view below changes done