Skip to content

NMC-552 Move filename/size out of the download button - #28643

Merged
skjnldsv merged 6 commits into
nextcloud:masterfrom
nextmcloud:NMC-552
Sep 2, 2021
Merged

NMC-552 Move filename/size out of the download button#28643
skjnldsv merged 6 commits into
nextcloud:masterfrom
nextmcloud:NMC-552

Conversation

@TSI-sangramdesai

Copy link
Copy Markdown
Contributor

Guest view below changes done

  1. For Video separated download button form file name and size
  2. For Image separated download button form file name and size

@Salvador1313Salvador1313 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusknorr

Copy link
Copy Markdown
Member

Please do not include the change in the 3rdparty submodule in here.

In addition the commit is missing a Signed-of-by message as described in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work

@juliusknorr
juliusknorr requested review from a team, PVince81, jancborchardt, skjnldsv and szaimen and removed request for a teamAugust 30, 2021 14:31
@juliusknorrjuliusknorr changed the title NMC-552NMC-552 Move filename/size out of the download buttonAug 30, 2021
@juliusknorrjuliusknorr added this to the Nextcloud 23 milestone Aug 30, 2021
Comment threadapps/files_sharing/templates/public.php Outdated
Comment threadapps/files_sharing/templates/public.php Outdated
@artonge

Copy link
Copy Markdown
Collaborator

I would also add some space above the downloadFile element. Adding the following in apps/files_sharing/css/public.scss should be enough:

.directDownload#downloadFile {
... margin-top: 16px;
}

@TSI-sangramdesai
TSI-sangramdesaiforce-pushed the NMC-552 branch 2 times, most recently from 085235c to 773898dCompareSeptember 1, 2021 13:03

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need DCO, else looks good :)

git rebase HEAD~6 --signoff
git push --force-with-lease origin NMC-552

Comment threadapps/files_sharing/templates/public.php
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com>
Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com>
Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com>
Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com>
Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com>
Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com>
Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
@skjnldsv
skjnldsv merged commit c37ed98 into nextcloud:masterSep 2, 2021
@welcome

welcomeBot commented Sep 2, 2021

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@skjnldsv

This comment has been minimized.

1 similar comment
@Pytal

Pytal commented Sep 2, 2021

Copy link
Copy Markdown
Member

/backport to stable22

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@TSI-sangramdesai@juliusknorr@artonge@skjnldsv@Pytal@Salvador1313