Skip to content

NMC-464 Highlight the search term on no results - #28682

Merged
szaimen merged 1 commit into
masterfrom
NMC-464
Sep 1, 2021
Merged

NMC-464 Highlight the search term on no results#28682
szaimen merged 1 commit into
masterfrom
NMC-464

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 1, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Supersede #28644

image

@skjnldsvskjnldsv added this to the Nextcloud 23 milestone Sep 1, 2021
@skjnldsv
skjnldsv requested a review from a teamSeptember 1, 2021 07:26
@skjnldsvskjnldsv self-assigned this Sep 1, 2021
@skjnldsv
skjnldsv requested review from PVince81, Pytal and szaimen and removed request for a teamSeptember 1, 2021 07:26
@skjnldsv

skjnldsv commented Sep 1, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@skjnldsvskjnldsv mentioned this pull request Sep 1, 2021
Closed
@skjnldsvskjnldsv changed the title Search function strong tag for user inputNMC-464 Highlight the search term on no results #28644Sep 1, 2021
@skjnldsvskjnldsv changed the title NMC-464 Highlight the search term on no results #28644NMC-464 Highlight the search term on no resultsSep 1, 2021
szaimen
szaimen approved these changes Sep 1, 2021
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen

This comment has been minimized.

Sign in to view
@skjnldsv

skjnldsv commented Sep 1, 2021

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@TSI-kavitasonawane@nextcloud-command
Search function strong tag for user input
d2aed25
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
szaimen merged commit 1a4e4b8 into masterSep 1, 2021
@szaimen
szaimen deleted the NMC-464 branch September 1, 2021 11:25
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 1, 2021
Merged
@skjnldsv

skjnldsv commented Sep 2, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@skjnldsv

skjnldsv commented Sep 2, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

Ah, already backported! Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwanCarlSchwanCarlSchwan approved these changes
@szaimenszaimenszaimen approved these changes
@PVince81PVince81Awaiting requested review from PVince81
@PytalPytalAwaiting requested review from Pytal
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@artongeartongeAwaiting requested review from artonge

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsenhancementhigh

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@szaimen@CarlSchwan@TSI-kavitasonawane