Skip to content

Profile page - #28751

Merged
Pytal merged 4 commits into
masterfrom
feat/28139/profile-page
Oct 19, 2021
Merged

Profile page#28751
Pytal merged 4 commits into
masterfrom
feat/28139/profile-page

Conversation

@Pytal

@PytalPytal commented Sep 7, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Tasks

  • Profile info and actions
    • Represent the info that is already set (DisplayName, Address, Avatar)
    • Required Profile actions
      • Account property actions (Email, Phone number, Website, Twitter)
      • Apps can register actions
      • Additional email actions
        • Order and scope of additional emails are not preserved, the logic for handling this is a prerequisite as visibility must also be preserved
    • Profile manager
      • Provide actions
      • Provide profile info
    • Privacy
      • Profile visibility
      • Respect already set scope settings
    • Display user status
  • Add new fields
    • Enable Profile checkbox (enabled by default)
      • Show error page when navigating to a disabled profile page
      • Don't show profile entrypoints when disabled
    • Organisation
    • Role
    • Biography
    • Headline
  • Profile entrypoints
    • Add entrypoint to your own profile in top-right user menu
    • Add profile preview card to personal info settings page
    • Add profile entrypoint to contacts menu as action and displayname link
    • Add profile entrypoint to Avatar menu through contacts menu actions provider (propagates to everything which uses ContactsMenuController)
  • Theming and dark mode work
  • Add necessary overrides (e.g. custom components, CSS overrides) for required functionality and UX
  • Make fields changes reactive (i.e. displayname, organisation, and profile enabled state changes are reflected instantly without needing a page reload)
  • Make it all look nice and work nicely together
  • Fix CI errors
  • Cleanup

Visual Reference

Profile page

image

Settings page

settings

Contributes to #28139

@PytalPytal added the 2. developing Work in progress label Sep 7, 2021
@PytalPytal added this to the Nextcloud 23 milestone Sep 7, 2021
@PytalPytal self-assigned this Sep 7, 2021
@Pytal
Pytal marked this pull request as draft September 7, 2021 14:11
@Pytal
Pytalforce-pushed the feat/28139/profile-page branch 2 times, most recently from 70633d6 to 9f313bbCompareSeptember 7, 2021 15:03
@PytalPytal mentioned this pull request Sep 7, 2021
Open
20 tasks
@Pytal
Pytalforce-pushed the feat/28139/profile-page branch 3 times, most recently from a7799d5 to db62eb4CompareSeptember 10, 2021 00:41
@PytalPytal added enhancement feature: settings feature: users and groups design Design, UI, UX, etc. feature: vue apps feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Sep 10, 2021
@Pytal
Pytalforce-pushed the feat/28139/profile-page branch 8 times, most recently from e3f286d to ae3fe4dCompareSeptember 17, 2021 21:32
@Pytal
Pytalforce-pushed the feat/28139/profile-page branch 5 times, most recently from a47399e to 3aaadbfCompareSeptember 25, 2021 02:07
@Pytal
Pytalforce-pushed the feat/28139/profile-page branch from 3aaadbf to 31f7f14CompareSeptember 30, 2021 03:29
@Pytal
Pytalforce-pushed the feat/28139/profile-page branch 4 times, most recently from 6985536 to 4bfa68fCompareOctober 15, 2021 19:25
@nickvergessennickvergessen mentioned this pull request Oct 15, 2021
Merged
@Pytal
Pytalforce-pushed the feat/28139/profile-page branch from f70d6f2 to 4ed65c1CompareOctober 15, 2021 19:43
@Pytal

Pytal commented Oct 15, 2021

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@Pytal@skjnldsv
Add profile templates
382ba66
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsv
skjnldsvforce-pushed the feat/28139/profile-page branch from 37983b7 to 727250aCompareOctober 18, 2021 07:00
@skjnldsv

skjnldsv commented Oct 18, 2021

Copy link
Copy Markdown
Member

/compile amend /

nickvergessen
nickvergessen reviewed Oct 18, 2021
View reviewed changes
Comment threadcore/Migrations/Version23000Date20210930122352.php
nickvergessen
nickvergessen reviewed Oct 18, 2021
View reviewed changes
Comment threadcore/Migrations/Version23000Date20210930122352.php
nickvergessen
nickvergessen reviewed Oct 18, 2021
View reviewed changes
Comment threadlib/private/Profile/Actions/EmailAction.php
if (empty($this->value)) {
return null;
}
return 'mailto:' . $this->value;

@nickvergessennickvergessenOct 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @tobiasKaminsky this will make sure the profiles API needs a rewrite when we want to bring all the actions to the clients. We should return the bare values and the rendering should make it a link or something like that?

blizzz
blizzz reviewed Oct 18, 2021
View reviewed changes
Comment threadapps/settings/lib/Settings/Personal/PersonalInfo.php
@Pytal
Pytalforce-pushed the feat/28139/profile-page branch 3 times, most recently from 1310e35 to f85cf8fCompareOctober 18, 2021 20:49
ChristophWurst
ChristophWurst approved these changes Oct 18, 2021
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed public API part and give it a smoke test

👍 :shipit:

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 18, 2021
@Pytal
Add new account properties
7215148
- New properties
- Organisation
- Role
- Headline
- Biography
- Profile Enabled property
- Fix errors with building default account properties
- Fix L10N factory method `getLanguage` not public error
- Update tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Profile backend
3093548
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Profile frontend
3be9d3c
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsvskjnldsv mentioned this pull request Oct 19, 2021
Closed
@MichaIngMichaIng mentioned this pull request Nov 12, 2021
Merged
@ChristophWurstChristophWurst mentioned this pull request Dec 7, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@blizzzblizzzblizzz left review comments
@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@artongeartongeAwaiting requested review from artonge
@julien-ncjulien-ncAwaiting requested review from julien-nc
@icewind1991icewind1991Awaiting requested review from icewind1991
@come-nccome-ncAwaiting requested review from come-nc
@PVince81PVince81Awaiting requested review from PVince81

Assignees

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.enhancementfeature: profilePRs or issues related to the Profile feature (e.g. Profile page, API, etc.)feature: settingsfeature: users and groupsfeature: vue apps

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

6 participants

@Pytal@nickvergessen@skjnldsv@PVince81@ChristophWurst@blizzz