Uh oh!
There was an error while loading. Please reload this page.
[stable22] Add database ratelimiting backend - #28814
Merged
Merged
Conversation
backportbot-nextcloudBot
requested review from
AndyScherzinger, ArtificialOwl, ChristophWurst, LukasReschke, PVince81, nickvergessen and skjnldsvSeptember 13, 2021 11:10
LukasReschke
commented
Sep 13, 2021
Member
Will manually backport. |
LukasReschkeforce-pushed
the
backport/28728/stable22
branch
from
September 13, 2021 13:34
4df9c0c to
c02e964CompareIn case no distributed memory cache is specified this adds a database backend for ratelimit purposes. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschkeforce-pushed
the
backport/28728/stable22
branch
from
September 13, 2021 13:36
c02e964 to
7eb702eCompareLukasReschke
approved these changes
Sep 13, 2021
Member
There was a problem hiding this comment.
Test plan:
- Disable the memory cache in
config.php - Enable the "Q&A Testing App" in the app settings
- Go to
/index.php/apps/testing/userAndAnonProtectedand click a few times. Verify that the requests fails due to hitting the ratelimit. - Verify that expired ratelimit entries are removed on requests
LukasReschke
commented
Sep 13, 2021
Member
Failing test seems unrelated. |
Pytal
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #28728