Uh oh!
There was an error while loading. Please reload this page.
[stable20] extend cache events - #28820
Merged
Merged
Conversation
- adds cache remove event - expose storage id in event - emit events during cache move Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloudBot
requested review from
ChristophWurst, MorrisJobke, icewind1991 and rullzerSeptember 13, 2021 15:56
Signed-off-by: Robin Appelman <robin@icewind.nl>
AndyScherzinger
requested review from
skjnldsv
and removed request for
MorrisJobkeSeptember 13, 2021 20:44
icewind1991
requested review from
juliusknorr
and removed request for
rullzerSeptember 15, 2021 12:11
blizzz
approved these changes
Sep 16, 2021
blizzz
left a comment
Member
There was a problem hiding this comment.
assuming (and finding to proof that is is otherwise) that CacheInsertEvent and CacheUpdateEvent are constructed internally only, as otherwise it would break compatibility for the changed constructor.
skjnldsv
approved these changes
Sep 16, 2021
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
commented
Sep 16, 2021
Member
Added a default value for fallback just in case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #24113