Uh oh!
There was an error while loading. Please reload this page.
Add new ExternalShareActions API - #28835
Merged
Merged
Conversation
skjnldsv
requested review from
a team, Pytal, artonge, juliusknorr and szaimen
and removed request for
a teamSeptember 14, 2021 15:46
skjnldsv
commented
Sep 14, 2021
MemberAuthor
/backport to stable22 |
Pytal
reviewed
Sep 15, 2021
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
blizzz
approved these changes
Sep 15, 2021
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
feat/ExternalShareActions-API
branch
from
September 16, 2021 13:23
adf7856 to
2213358Compare
This comment has been minimized.
This comment has been minimized.
skjnldsvforce-pushed
the
feat/ExternalShareActions-API
branch
2 times, most recently
from
September 16, 2021 15:33
5413a9e to
b1572c9CompareSigned-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
feat/ExternalShareActions-API
branch
from
September 16, 2021 16:12
b1572c9 to
cbe406eCompare6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See example:
nextcloud/files_downloadlimit#5
https://github.com/nextcloud/files_downloadlimit/blob/32ae1dbf2df12a262f849af07ef4c4ea8f7c3cfd/src/main.js
https://github.com/nextcloud/files_downloadlimit/blob/32ae1dbf2df12a262f849af07ef4c4ea8f7c3cfd/src/models/DownloadLimitAction.js
This API is a more global way of injecting entries into the link share menu.
It can be any type currently supported by the vue components.
In opposite of the old (and now legacy deprecated) API that only allowed links (for the social app).