Uh oh!
There was an error while loading. Please reload this page.
Don't allow to change activity settings that don't work - #28853
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
There was a problem hiding this comment.
Not sure if I've done something wrong but the checkboxes are not disabled, afaics. (I can still trigger those options)
See:
I've used this branch and tested it together with the activity master branch:
click here
docker run -d \
-e SERVER_BRANCH=bugfix/27547/dont-allow-changing-settings-that-dont-work \
-e ACTIVITY_BRANCH=master \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.178.34 \
--name nextcloud-easy-test \
--user=www-data \
ghcr.io/szaimen/nextcloud-easy-test:latest
nickvergessen
commented
Sep 15, 2021
Your eyes are tricking you.the options you see are not about favorites, but all files. The favorite line disappeared as you cant change any of the values in that row it does not make sense to show it. |
You are right. I've compared it to a current instance and the option is now indeed gone :) |
szaimen
commented
Sep 15, 2021
/backport to stable22 |
szaimen
commented
Sep 15, 2021
/backport to stable21 |
szaimen
commented
Sep 15, 2021
/backport to stable20 |
Ref #27547 (comment)
Close#27547
Closenextcloud/activity#526