Skip to content

Fix files view change and undefined currentFileList - #28872

Merged
Pytal merged 1 commit into
masterfrom
fix/files-view-undefined-currentFileList
Sep 17, 2021
Merged

Fix files view change and undefined currentFileList#28872
Pytal merged 1 commit into
masterfrom
fix/files-view-undefined-currentFileList

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 17, 2021

Copy link
Copy Markdown
Member

Fix#26672

Steps

  1. Favourite a file
  2. Go to favourites
  3. Open file menu and click "View in folder"
  4. Try to create a file

Explanations

Because the change is set to silent, we don't emit the jQuery event to dispatch the view change.
So the app is not fully instantiated on the new view.

server/apps/files/js/navigation.js

Lines 153 to 168 in f13b3ab

if(!options||!options.silent){
this.$currentContent.trigger(jQuery.Event('show',{
itemId: itemId,
previousItemId: oldItemId,
dir: itemDir,
view: itemView
}));
this.$el.trigger(
new$.Event('itemChanged',{
itemId: itemId,
previousItemId: oldItemId,
dir: itemDir,
view: itemView
})
);
}

@skjnldsv
Fix files view change and undefined currentFileList
f781135
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added this to the Nextcloud 23 milestone Sep 17, 2021
@skjnldsv
skjnldsv requested a review from a teamSeptember 17, 2021 08:44
@skjnldsvskjnldsv self-assigned this Sep 17, 2021
@skjnldsv
skjnldsv requested review from PVince81, artonge and szaimen and removed request for a teamSeptember 17, 2021 08:44
@skjnldsv

skjnldsv commented Sep 17, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@skjnldsv

skjnldsv commented Sep 17, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@skjnldsv

skjnldsv commented Sep 17, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@skjnldsv
skjnldsv requested a review from PytalSeptember 17, 2021 08:44
@skjnldsvskjnldsv mentioned this pull request Sep 17, 2021
Closed
PVince81
PVince81 approved these changes Sep 17, 2021
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pytal

Pytal commented Sep 17, 2021

Copy link
Copy Markdown
Member

⚙ failure unrelated

@Pytal
Pytal merged commit b033d57 into masterSep 17, 2021
@Pytal
Pytal deleted the fix/files-view-undefined-currentFileList branch September 17, 2021 19:52
@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 17, 2021
This was referenced Sep 17, 2021
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@PytalPytalPytal approved these changes
@artongeartongeAwaiting requested review from artonge
@szaimenszaimenAwaiting requested review from szaimen

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: files

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

Alert “Unable to create new file from template”

3 participants

@skjnldsv@Pytal@PVince81