Skip to content

Update app versions for 23 - #28977

Merged
nickvergessen merged 2 commits into
masterfrom
update-apps-for-23
Sep 29, 2021
Merged

Update app versions for 23#28977
nickvergessen merged 2 commits into
masterfrom
update-apps-for-23

Conversation

@PVince81

@PVince81PVince81 commented Sep 28, 2021

Copy link
Copy Markdown
Member

As discussed with @blizzz, we usually make sure that there is a minor version increment to match a major Nextcloud release.

@PVince81
Update app versions for 23
5a6a0b0
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81PVince81 added the 3. to review Waiting for reviews label Sep 28, 2021
@PVince81PVince81 self-assigned this Sep 28, 2021
@blizzz

blizzz commented Sep 28, 2021

Copy link
Copy Markdown
Member

As discussed with @blizzz, we usually make sure that there is a minor version increment to match a major Nextcloud release.

We have collisions in stable21 and stable22, so need to bump here in master – making room for 22 – and then also in stable22.

Example:
Systemtags 21: https://github.com/nextcloud/server/blob/stable21/apps/systemtags/appinfo/info.xml#L9
Systemtags 22: https://github.com/nextcloud/server/blob/stable22/apps/systemtags/appinfo/info.xml#L9

@blizzzblizzz added this to the Nextcloud 23 milestone Sep 28, 2021
nickvergessen
nickvergessen approved these changes Sep 28, 2021
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did i miss that in #25454

So yeah we need a +0.1 in master and stable22 i guess

@kesselb

This comment has been minimized.

Sign in to view
@kesselb

This comment has been minimized.

Sign in to view
@blizzz

blizzz commented Sep 28, 2021

Copy link
Copy Markdown
Member

How did i miss that in #25454

So yeah we need a +0.1 in master and stable22 i guess

happens to the best. would be good to have 22 done tomorrow to include it into the release.

@nickvergessen
Fix unit tests
a586739
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

nickvergessen commented Sep 29, 2021

Copy link
Copy Markdown
Member

Fixed the tests

@nickvergessennickvergessen mentioned this pull request Sep 29, 2021
Merged
@nickvergessennickvergessen added 4. to release Ready to be released and/or waiting for tests to finish bug and removed 3. to review Waiting for reviews labels Sep 29, 2021
@nickvergessen
nickvergessen merged commit 5a469f5 into masterSep 29, 2021
@nickvergessen
nickvergessen deleted the update-apps-for-23 branch September 29, 2021 08:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@blizzzblizzzblizzz approved these changes
@kesselbkesselbkesselb approved these changes
@artongeartongeAwaiting requested review from artongeartonge is a code owner
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan
@szaimenszaimenAwaiting requested review from szaimenszaimen is a code owner
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurstChristophWurst is a code owner

Assignees

@PVince81PVince81

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

4 participants

@PVince81@blizzz@kesselb@nickvergessen