Skip to content

Send the subscription key to the appstore requests - #29235

Merged
skjnldsv merged 1 commit into
masterfrom
feat/appstore/enterprise
Oct 15, 2021
Merged

Send the subscription key to the appstore requests#29235
skjnldsv merged 1 commit into
masterfrom
feat/appstore/enterprise

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Oct 14, 2021

Copy link
Copy Markdown
Member

Last part of #28569

@skjnldsv
skjnldsv requested review from a team, CarlSchwan, PVince81 and nickvergessen and removed request for a teamOctober 14, 2021 09:58
@skjnldsvskjnldsv self-assigned this Oct 14, 2021
@skjnldsv
skjnldsv requested a review from blizzzOctober 14, 2021 09:58
@skjnldsvskjnldsv added 3. to review Waiting for reviews enhancement labels Oct 14, 2021
@skjnldsvskjnldsv added this to the Nextcloud 23 milestone Oct 14, 2021
Comment threadlib/private/App/AppStore/Fetcher/Fetcher.php Outdated
@blizzz

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@skjnldsv
skjnldsvforce-pushed the feat/appstore/enterprise branch from a435fc3 to b554234CompareOctober 14, 2021 12:37
@skjnldsv
skjnldsvforce-pushed the feat/appstore/enterprise branch from b554234 to c91b238CompareOctober 14, 2021 12:39

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the feat/appstore/enterprise branch from c91b238 to 1f76423CompareOctober 14, 2021 12:48

/** @var IRegistry */
private $registry;
protected $registry;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected $registry;

I think this can go.

@skjnldsv
skjnldsv merged commit b6a3ba1 into masterOct 15, 2021
@skjnldsv
skjnldsv deleted the feat/appstore/enterprise branch October 15, 2021 09:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@blizzz@nickvergessen@kesselb