Skip to content

Add option to restore automatic status - #29430

Closed
CarlSchwan wants to merge 7 commits into
masterfrom
revert_automatic_status
Closed

Add option to restore automatic status#29430
CarlSchwan wants to merge 7 commits into
masterfrom
revert_automatic_status

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Oct 25, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@CarlSchwan
CarlSchwan marked this pull request as draft October 25, 2021 12:46
@CarlSchwan
CarlSchwanforce-pushed the revert_automatic_status branch from 2a062f6 to b294de2CompareNovember 4, 2021 15:29
@CarlSchwan

CarlSchwan commented Nov 4, 2021

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@CarlSchwanCarlSchwan added the 3. to review Waiting for reviews label Nov 4, 2021
@CarlSchwanCarlSchwan self-assigned this Nov 4, 2021
@CarlSchwan
CarlSchwan marked this pull request as ready for review November 4, 2021 15:44
@CarlSchwan@nextcloud-command
fixup! Fix the remaining bugs
4e8141c
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nickvergessen
nickvergessen reviewed Nov 4, 2021
View reviewed changes
Comment threadapps/user_status/src/store/backupUserStatus.js
Comment threadapps/user_status/src/store/userStatus.js
Comment threadapps/user_status/src/components/ResetStatus.vue Outdated
Comment on lines +25 to +31
{{ $t('user_status', 'Reset to') }}
<a
href="#"
role="button"
@click.prevent.stop="revertCurrentStatus">
{{ message }}
</a>

@nickvergessennickvergessenNov 4, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#improving-your-translations please make the message a parameter in the translation, or use another line break and make the translated string "complete" e.g. Reset status: and use a real button?

Comment threadapps/user_status/appinfo/routes.php Outdated
@nickvergessen

nickvergessen commented Nov 4, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Internal Server Error\nArgument 1 passed to OCA\UserStatus\Controller\UserStatusController::setPredefinedMessage() must be of the type string, null given, called in server/lib/private/AppFramework/Http/Dispatcher.php on line 217 in file 'server/apps/user_status/lib/Controller/UserStatusController.php' line 133

Not sure how I created this, it was random clicking around between status (online/away/...) and predefined statuses

@jancborchardt

jancborchardt commented Nov 4, 2021

Copy link
Copy Markdown
Member

This note should show below the input field for the status message though, as it's related to the message. Right?

@CarlSchwanCarlSchwan changed the title Revert automatic statusRestore automatic statusNov 4, 2021
@jancborchardt

jancborchardt commented Nov 29, 2021

Copy link
Copy Markdown
Member

This note should show below the input field for the status message though, as it's related to the message. Right?

@CarlSchwan was that fixed? Also it seems this needs rebasing, mind updating the screenshot afterwards? :)

@PVince81

PVince81 commented Jun 10, 2022

Copy link
Copy Markdown
Member

did we not fix this differently ? or have plans for it in a different context ? @CarlSchwan@nickvergessen

@nickvergessen

nickvergessen commented Jun 10, 2022

Copy link
Copy Markdown
Member

This would still be highly appiciated

@nickvergessennickvergessen changed the title Restore automatic statusAdd option to restore automatic statusJun 13, 2022
@nickvergessennickvergessen added this to the Nextcloud 25 milestone Jun 13, 2022
jancborchardt
jancborchardt requested changes Jun 16, 2022
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note should show below the input field for the status message though, as it's related to the message.

@skjnldsvskjnldsv mentioned this pull request Aug 12, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 7, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzzblizzz mentioned this pull request May 17, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 27, Nextcloud 28May 23, 2023
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@skjnldsv

skjnldsv commented Feb 24, 2024

Copy link
Copy Markdown
Member

cc @nickvergessen do we still need this?
also cc @ChristophWurst as it seems groupware also have meeting automated statuses

@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 24, 2024
@nickvergessen

nickvergessen commented Feb 24, 2024

Copy link
Copy Markdown
Member

I implemented this already some time ago

@skjnldsv
skjnldsv deleted the revert_automatic_status branch February 24, 2024 18:25
@skjnldsvskjnldsv removed the 2. developing Work in progress label Feb 24, 2024
@skjnldsvskjnldsv removed this from the Nextcloud 29 milestone Feb 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@jancborchardtjancborchardtjancborchardt requested changes
@artongeartongeAwaiting requested review from artonge

Assignees

@CarlSchwanCarlSchwan

Labels

enhancementfeature: status

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing action to revert the status back after an auto change in calendar/talk

6 participants

@CarlSchwan@nickvergessen@jancborchardt@PVince81@skjnldsv@blizzz