Uh oh!
There was an error while loading. Please reload this page.
Add IManager::getCalendarsForPrincipal API - #29533
Merged
ChristophWurst merged 1 commit intoNov 4, 2021
Merged
Conversation
The Calendar app needs to access calendars of a given principal in the back-end. The new calendar providers were not accessible for apps before this patch. Now they can access the ICalendar objects on demand. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
commented
Nov 3, 2021
MemberAuthor
It worked, right? |
ChristophWurst
marked this pull request as ready for review
November 3, 2021 18:33
ChristophWurst
commented
Nov 3, 2021
MemberAuthor
To be decided if this goes into 23 or 24 |
ChristophWurst
requested review from
juliusknorr, nickvergessen, skjnldsv and tcitworldNovember 3, 2021 18:34
miaulalala
approved these changes
Nov 3, 2021
ChristophWurst
deleted the
enhancement/get-calendars-for-principal-api
branch
November 4, 2021 06:33
This was referenced Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Calendar app needs to access calendars of a given principal in the
back-end. The new calendar providers were not accessible for apps before
this patch. Now they can access the ICalendar objects on demand.
The logic for the new method was already in
searchForPrincipal, so I only had to extract that into a new method and make it publicly accessible.Required for nextcloud/calendar#3478
@miaulalala please give this a test and see if it meets our requirements.