Uh oh!
There was an error while loading. Please reload this page.
[stable21] Fix removing remote shares when the remote server is unreachable - #29564
Closed
backportbot-nextcloud[bot] wants to merge 6 commits into
Closed
[stable21] Fix removing remote shares when the remote server is unreachable#29564backportbot-nextcloud[bot] wants to merge 6 commits into
backportbot-nextcloud[bot] wants to merge 6 commits into
Conversation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The federated server needs to be stopped during the tests, so it is now stopped in the FederationContext for each scenario instead of just once in the run.sh script. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Technically, saying that a storage has no updates when it's not available is correct. This makes it possible to retrieve the cache entry for the mount point and also to list and remove unavailable federated shares. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com> Co-authored-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloudBot
requested review from
CarlSchwan, danxuliu, icewind1991, juliusknorr, nickvergessen and skjnldsvNovember 5, 2021 13:56
PVince81
commented
Nov 5, 2021
Member
let's hold for now as this changes the behavior of unavailable external storages |
MichaIng
approved these changes
Nov 6, 2021
skjnldsv
approved these changes
Nov 8, 2021
szaimen
commented
Nov 8, 2021
Contributor
Does it fix #20995? |
blizzz
commented
Nov 10, 2021
Member
moved to 21.0.7 |
blizzz
commented
Feb 11, 2022
Member
@PVince81 how to go forward with this PR? |
blizzz
commented
Mar 21, 2022
Member
no reply, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #25332