Uh oh!
There was an error while loading. Please reload this page.
Bump marked from 3.0.7 to 4.0.0 - #29580
Closed
dependabot[bot] wants to merge 2 commits into
Closed
Conversation
Bumps [marked](https://github.com/markedjs/marked) from 3.0.7 to 4.0.0. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json) - [Commits](markedjs/marked@v3.0.7...v4.0.0) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
MichaIng
requested changes
Nov 6, 2021
Member
There was a problem hiding this comment.
BREAKING CHANGES
- Default export removed. Use
import { marked } from 'marked'orconst { marked } = require('marked')instead./lib/marked.jsremoved. Use/marked.min.jsin script tag instead.- When using marked in a script tag use
marked.parse(...)instead ofmarked(...)
There is no way an external app can rely on this, is it?
Setting on hold just in case this may cause issues when auto-merged to master/Nextcloud 23 branch.
MichaIng
commented
Nov 6, 2021
Member
/compile amend / |
Signed-off-by: MichaIng <micha@dietpi.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
dependabot/npm_and_yarn/marked-4.0.0
branch
from
November 6, 2021 12:53
af861ac to
a72deabCompareMichaIng
commented
Nov 6, 2021
Member
And Drone keeps ignoring marked update PRs:
Usually merging and reviewing afterwards is fine, but here we have a major version bump 🤔. |
artonge
commented
Nov 9, 2021
Collaborator
@skjnldsv see above comment, should we wait after 23 release? |
ContributorAuthor
A newer version of marked exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
MichaIng
commented
Nov 11, 2021
Member
@dependabot recreate |
ContributorAuthor
Superseded by #29665. |
This was referenced Nov 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps marked from 3.0.7 to 4.0.0.
Release notes
Sourced from marked's releases.
Commits
7c09bb0chore(release): 4.0.0 [skip ci]1d5966f🗜️ build [skip ci]eb84a28chore: rename release config4afb228fix: Convert to ESM (#2227)911dc9cchore(deps-dev): Bump@babel/preset-envfrom 7.15.8 to 7.16.0 (#2263)19466ffchore(deps-dev): Bump rollup from 2.58.3 to 2.59.0 (#2262)49ad2eachore(deps-dev): Bump@babel/corefrom 7.15.8 to 7.16.0 (#2261)a702a8fchore(deps-dev): Bump@semantic-release/gitfrom 10.0.0 to 10.0.1 (#2260)e93f800chore(deps-dev): Bump rollup from 2.58.0 to 2.58.3 (#2258)d23f94fchore(deps-dev): Bump@semantic-release/npmfrom 8.0.1 to 8.0.2 (#2254)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)