Uh oh!
There was an error while loading. Please reload this page.
Fix loading all principal calendars in the dav app calendar provider - #29663
Merged
Merged
Conversation
If we load all calendar infos of a principal then we get back an array and not a single calendar info. This was handled incorrectly and an array of calendar infos were passed to the calendar implementation, resulting in interesting bugs. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
a team, miaulalala, st3iny and tcitworldNovember 11, 2021 12:32
ChristophWurst
requested review from
ArtificialOwl, come-nc and nickvergessen
and removed request for
a teamNovember 11, 2021 12:32
ChristophWurst
commented
Nov 11, 2021
MemberAuthor
/backport to stable23 |
tcitworld
approved these changes
Nov 11, 2021
ChristophWurst
commented
Nov 11, 2021
MemberAuthor
💯 unrelated |
miaulalala
approved these changes
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we load all calendar infos of a principal then we get back an array
and not a single calendar info. This was handled incorrectly and an
array of calendar infos were passed to the calendar implementation,
resulting in interesting bugs.