Uh oh!
There was an error while loading. Please reload this page.
Only add the vue exeption to actual button elements - #29905
Conversation
Signed-off-by: marco <marcoambrosini@pm.me>
ChristophWurst
commented
Nov 25, 2021
Do you have examples of where this helps or not? I'm not able to verify it would actually fix the regressions |
marcoambrosini
commented
Nov 25, 2021
There is this nextcloud-libraries/nextcloud-vue#2371 |
Valdnet
commented
Nov 25, 2021
As for me, it works fine after the changes 👍. @marcoambrosini Thanks for the memory and fix 😉. |
ChristophWurst
commented
Dec 1, 2021
will we backport to 22 as well? |
st3iny
left a comment
There was a problem hiding this comment.
Fixes nextcloud-libraries/nextcloud-vue#2371 but does not fix #29591.
However, I just realized that the button regression in calendar is caused by a local css rule. We should fix it in the calendar repo directly.
st3iny
commented
Dec 1, 2021
PS: I could not reproduce the reply button problem from #29591. It's working fine for me with and without this patch. |
marcoambrosini
commented
Dec 1, 2021
Yes I think we should |
blizzz
commented
Dec 1, 2021
if you backport to 22, backport to 23, too |
skjnldsv
commented
Dec 1, 2021
/backport to stable23 |
skjnldsv
commented
Dec 1, 2021
/backport to stable22 |
Fixes#29591