Fix users can't login external mount user entered credentials not set

[alacn1]

When using external mount with "Global credentials, user entered", users without it set won't be able to login.
This happens because BasicAuth requires username and password as string, but will be null when user didn't set it yet.

It happens because since the commit: 66781e7 update icewind/smb to 3.4.0
the file apps/files_external/3rdparty/icewind/smb/src/BasicAuth.php was changed to use php 7.4 typed properties.

-	public function __construct($username, $workgroup, $password) {
+	public function __construct(string $username, ?string $workgroup, string $password) {

BasicAuth with username as null throws TypeError:

Argument 1 passed to Icewind\\SMB\\BasicAuth::__construct() must be of the type string, null given, called in apps/files_external/lib/Lib/Backend/SMB.php on line 82

apps/files_external/lib/Lib/Backend/SMB.php

public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
[...]
$smbAuth = new BasicAuth(
$storage->getBackendOption('user'),
$storage->getBackendOption('domain'),
$storage->getBackendOption('password')
);

TypeError is a subclass of Error, not a subclass of Exception, it won't catch it at FailedStorage:

apps/files_external/lib/Config/ConfigAdapter.php

public function getMountsForUser(IUser $user, IStorageFactory $loader) {
[...]
$storages = array_map(function (StorageConfig $storageConfig) use ($user) {
try {
$this->prepareStorageConfig($storageConfig, $user);
return $this->constructStorage($storageConfig);
} catch (\Exception $e) {
// propagate exception into filesystem
return new FailedStorage(['exception' => $e]);
}
}, $storageConfigs);

The proposed fix is to check if user and password is string instead of null, and throw InvalidArgumentException if it's not.

apps/files_external/lib/Lib/Backend/SMB.php

public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
[...]
if(!is_string($storage->getBackendOption('user')) || !is_string($storage->getBackendOption('password')))
throw new \InvalidArgumentException('user or password is not set');

This commit can be cherry-picked to master, stable22, stable21.

Fix#28229 .
Fix#26697 .
Stable22 PR #29638 .

[PVince81]

👍

[PVince81]

seems this breaks some FTP tests

[alacn1]

@PVince81 I didn't touch FTP, and FTP doesn't depend on this file. I think it's the master tip commit that is broken. Should I rebase to newer master and force push?

[alacn1]

Rebased to master tip.

[alacn1]

fixed php-cs complaints.

[solracsf]

/backport to stable23

[solracsf]

/backport to stable22

[solracsf]

/backport to stable21

[alacn1]

again, the failing checks is unrelated with the patch.

[PVince81]

I've restarted the static code checker, it seems it had an issue starting.

once it passes we can merge this as everything else was green

[CarlSchwan]

Psalm issue is unrelated and will be fixed then rebasing :)

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[CarlSchwan]

/backport to stable22

[CarlSchwan]

/backport to stable21