allow to override prefers-color-scheme via url param for guests

[jonathanmmm]

using ?force-color-scheme=light should make the theme light and ?force-color-scheme=dark should make it dark.
Useful for iframes to match a website theme and to send a specific theme to a guest.

I couldn't test it locally, as it seems that javascript is somehow like compiled (and the src folder is missing for example) and have no developer setup. If needed, I can set one up.

My first pull request to nextcloud, if you have feedback how to make it better next time, tell me.

[jonathanmmm]

Could solve this issue: #29699

[szaimen]

/compile amend /

[jonathanmmm]

Ok, somehow it doesn't do anything.
Seems to be that /server/apps/accessibility/lib/AppInfo/Application.php
`$userValues = ['dark'];

 $hash = md5(implode('-', $userValues));
$linkToCSS = $urlGenerator->linkToRoute(self::APP_ID . '.accessibility.getCss', ['md5' => $hash]);
\OCP\Util::addHeader('link', ['rel' => 'stylesheet', 'media' => '(prefers-color-scheme: dark)', 'href' => $linkToCSS]);
\OCP\Util::addScript('accessibility', 'accessibilityoca');`

If I put into the third line light instead of dark it changes to light theme.
Testing in incognito mode.

Does somebody know, if accessibilityoca.js in src has to be compiled and lands then in the js folder?

Don't know how these js files with the super long lines work, are they compiled or do I have to change them too?

This pull and commit seem to made prefer-color-scheme possible in the first place https://github.com/nextcloud/server/pull/21366/files
ede5db1

[jonathanmmm]

@CarlSchwan If you have motivation+time, we could takle this feature together.

[jonathanmmm]

Research:

2916402
override these changes in the commit if url parameter is given
line 75-82: https://github.com/nextcloud/server/blob/master/apps/accessibility/lib/AppInfo/Application.php
line 113-117: https://github.com/nextcloud/server/blob/master/apps/accessibility/lib/Controller/AccessibilityController.php

and change it so that line 27-30 the value in line 29 is not changed if url parameter is given
https://github.com/nextcloud/server/blob/master/apps/accessibility/src/accessibilityoca.js

[jonathanmmm]

@CarlSchwan It is working now when dark mode is enabled in the system (forcing light mode), but not the other way around and I don't know. I even tried and replaced every theme--light string I could find under accessibility and replaced it with theme--dark, still light mode.

[skjnldsv]

As there is no feedback since a while I will close this ticket.
If you will decide to work on this feature again and if it hasn't been fixed or implemented already, feel free to re-open and solve the various conflicts.

Thanks for the interest in Nextcloud and the effort put into this! 🙇