Skip to content

Remove iconv from dependencies and tests - #29958

Merged
MichaIng merged 1 commit into
masterfrom
fix/translit-php8/deps-and-tests
Nov 30, 2021
Merged

Remove iconv from dependencies and tests#29958
MichaIng merged 1 commit into
masterfrom
fix/translit-php8/deps-and-tests

Conversation

@MichaIng

@MichaIngMichaIng commented Nov 29, 2021

Copy link
Copy Markdown
Member

which is not used anymore since: #29470

When accepted, requires an update of the documentation which I'll then commit as well.

@MichaIngMichaIng added the 3. to review Waiting for reviews label Nov 29, 2021
@MichaIngMichaIng added this to the Nextcloud 24 milestone Nov 29, 2021
@MichaIngMichaIng added pending documentation This pull request needs an associated documentation update dependencies and removed dependencies labels Nov 29, 2021
@CarlSchwan

Copy link
Copy Markdown
Member

/backport to stable21

@CarlSchwan

Copy link
Copy Markdown
Member

/backport to stable22

@CarlSchwan

Copy link
Copy Markdown
Member

/backport to stable23

@MichaIng

Copy link
Copy Markdown
MemberAuthor

Let me create backports for #29470 first.

@MichaIng
MichaIngforce-pushed the fix/translit-php8/deps-and-tests branch 2 times, most recently from b159b58 to 01d1a33CompareNovember 29, 2021 23:48
which is not used anymore since: #29470
Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng
MichaIngforce-pushed the fix/translit-php8/deps-and-tests branch from 01d1a33 to 0d749b7CompareNovember 30, 2021 01:33
@MichaIng
MichaIng merged commit d16d4d3 into masterNov 30, 2021
@MichaIng
MichaIng deleted the fix/translit-php8/deps-and-tests branch November 30, 2021 12:07
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable23 failed. Please do this backport manually.

MichaIng added a commit that referenced this pull request Dec 20, 2021
as of: #29470
Some tests were missing in: #29958
Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng added a commit to nextcloud/documentation that referenced this pull request Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470
The dependency has been removed in: nextcloud/server#29958
Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng

MichaIng commented Dec 20, 2021

Copy link
Copy Markdown
MemberAuthor

Related documentation change is proposed here: nextcloud/documentation#7860

backportbot-nextcloudBot pushed a commit to nextcloud/documentation that referenced this pull request Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470
The dependency has been removed in: nextcloud/server#29958
Signed-off-by: MichaIng <micha@dietpi.com>
backportbot-nextcloudBot pushed a commit to nextcloud/documentation that referenced this pull request Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470
The dependency has been removed in: nextcloud/server#29958
Signed-off-by: MichaIng <micha@dietpi.com>
backportbot-nextcloudBot pushed a commit to nextcloud/documentation that referenced this pull request Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470
The dependency has been removed in: nextcloud/server#29958
Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng added a commit that referenced this pull request Dec 31, 2021
as of: #29470
Some tests were missing in: #29958
Signed-off-by: MichaIng <micha@dietpi.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewspending documentationThis pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaIng@CarlSchwan@come-nc@skjnldsv