Uh oh!
There was an error while loading. Please reload this page.
[stable21] Add repair job to delete calendar subscriptions that were orphaned when deleting an user - #30006
Closed
backportbot-nextcloud[bot] wants to merge 2 commits into
Closed
[stable21] Add repair job to delete calendar subscriptions that were orphaned when deleting an user#30006backportbot-nextcloud[bot] wants to merge 2 commits into
backportbot-nextcloud[bot] wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
MichaIngforce-pushed
the
backport/28716/stable21
branch
from
January 12, 2022 19:37
a008686 to
43d9936CompareMichaIngforce-pushed
the
backport/28716/stable21
branch
from
January 14, 2022 18:22
43d9936 to
a4245efCompareskjnldsv
requested review from
a team, MichaIng, PVince81, icewind1991 and skjnldsv
and removed request for
a teamJanuary 20, 2022 09:41
skjnldsv
approved these changes
Jan 20, 2022
blizzz
commented
Feb 11, 2022
Member
still waiting for a second review |
MichaIng
approved these changes
Feb 11, 2022
miaulalala
requested changes
Feb 14, 2022
| $qb = $this->connection->getQueryBuilder(); | ||
| $qb->delete('calendarsubscriptions') | ||
| ->where($qb->expr()->eq('id', $qb->createNamedParameter($orphanSubscriptionID))) | ||
| ->executeStatement(); |
Member
There was a problem hiding this comment.
Suggested change
| ->executeStatement(); | |
| ->execute(); |
| $qb->method('createNamedParameter')->willReturn($this->createMock(IParameter::class)); | ||
| $qb->method('where')->willReturn($qb); | ||
| // Only when user exists | ||
| $qb->expects($this->exactly($deletions))->method('executeStatement'); |
Member
There was a problem hiding this comment.
Suggested change
| $qb->expects($this->exactly($deletions))->method('executeStatement'); | |
| $qb->expects($this->exactly($deletions))->method('execute'); |
deleteding an user Follow-up to #28419 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
MichaIngforce-pushed
the
backport/28716/stable21
branch
from
February 14, 2022 23:36
0038a69 to
3e7b3ceCompareChristophWurst
commented
Mar 21, 2022
Member
We decided it isn't worth the risk backporting this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #28716