Uh oh!
There was an error while loading. Please reload this page.
Use correct icon for dir-external-root - #30164
Merged
Merged
Conversation
When an external storage mount is shared with circles, it triggers the share icon state to be rerendered. The picking of the mime type icon would use the regular file icon because there is no actual icon for "dir-external-root" that is shared. This fixes the logic to use the "folder-external" icon in such scenarios. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
commented
Dec 9, 2021
MemberAuthor
/backport to stable23 |
PVince81
commented
Dec 9, 2021
MemberAuthor
/backport to stable22 |
PVince81
commented
Dec 9, 2021
MemberAuthor
/backport to stable21 |
CarlSchwan
approved these changes
Dec 9, 2021
PVince81
requested review from
a team, artonge, skjnldsv and szaimen
and removed request for
a teamDecember 10, 2021 09:19
This was referenced Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an external storage mount is shared with circles, it triggers the
share icon state to be rerendered. The picking of the mime type icon
would use the regular file icon because there is no actual icon for
"dir-external-root" that is shared.
This fixes the logic to use the "folder-external" icon in such
scenarios.
Note: the actual bug only seems to appear on stable21 because of another bug that prevents the share status to be displayed on the row (to be raised separately)