Uh oh!
There was an error while loading. Please reload this page.
Fix ShareLink Upload UI for Folders - #30256
Merged
Merged
Conversation
Do not show the Upload-Option if it is not allowed to check. Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
requested review from
PVince81, artonge, marcoambrosini, nickvergessen and skjnldsvDecember 14, 2021 00:13
jotoeri
commented
Dec 14, 2021
MemberAuthor
/compile amend/ |
jotoeri
commented
Dec 14, 2021
MemberAuthor
/backport to stable23 |
jotoeri
commented
Dec 14, 2021
MemberAuthor
/backport to stable22 |
jotoeri
commented
Dec 14, 2021
MemberAuthor
/backport to stable21 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
artonge
approved these changes
Dec 14, 2021
The backport to stable23 failed. Please do this backport manually. |
The backport to stable22 failed. Please do this backport manually. |
The backport to stable21 failed. Please do this backport manually. |
jotoeri
commented
Dec 14, 2021
MemberAuthor
Somebody knows, why this happens? 🤔 |
This was referenced Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix of a quite old bug i stumbled upon today. The Upload-options for folders are shown only if the user has permissions to do so. If permissions are not given, until now it fell back to the option for files instead of showing nothing.
Fixes#27962
Corresponding v-if:
server/apps/files_sharing/src/components/SharingEntryLink.vue
Line 155 in e006491
Showing the bug: files option on folder
