Uh oh!
There was an error while loading. Please reload this page.
Fix share owner not being displayed in sharing tab - #30266
Merged
Conversation
CarlSchwan
requested review from
a team, PVince81, Pytal and artonge
and removed request for
a teamDecember 14, 2021 12:36
Pytal
commented
Dec 14, 2021
Member
/compile amend / |
nextcloud-commandforce-pushed
the
fix/share-not-being-displayed-tab
branch
from
December 14, 2021 21:15
9b3234d to
71d2578CompareCarlSchwanforce-pushed
the
fix/share-not-being-displayed-tab
branch
from
December 14, 2021 21:15
71d2578 to
ebc49a4CompareCarlSchwan
commented
Dec 14, 2021
MemberAuthor
/compile amend / |
Pytal
reviewed
Dec 14, 2021
Pytal
left a comment
Member
There was a problem hiding this comment.
As the folder owner somehow it got to this state
due to this.fileInfo.shareOwnerId being undefined but not sure why 🤷♂️
nextcloud-commandforce-pushed
the
fix/share-not-being-displayed-tab
branch
from
December 14, 2021 21:26
ebc49a4 to
5148c5fCompareCarlSchwan
commented
Dec 14, 2021
MemberAuthor
Yeah I noticed that and forgot to push the change. Now I need to fix the conflict and compile the assets again |
CarlSchwanforce-pushed
the
fix/share-not-being-displayed-tab
branch
from
December 14, 2021 21:51
5148c5f to
e577308CompareCarlSchwan
commented
Dec 14, 2021
MemberAuthor
/compile amend / |
This only concerns subfolder and files inside a shared folder and is used as fallback when the OCS api returns a empty result, because it only works on the shared folder and not the content inside of it. This unify the tab with the folder list. This offers a less descriptive share information but making the OCS api returns all the details even for the subfolder would very probably be bad for performance (since we would need to fetch the shares for all the parent folders until we found one or are in the root folder). Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
fix/share-not-being-displayed-tab
branch
from
December 14, 2021 22:00
e577308 to
9c4cf73ComparePytal
approved these changes
Dec 15, 2021
skjnldsv
approved these changes
Dec 16, 2021
skjnldsv
commented
Dec 16, 2021
Member
Backports? |
CarlSchwan
commented
Dec 17, 2021
MemberAuthor
/backport to stable23 |
CarlSchwan
commented
Dec 17, 2021
MemberAuthor
/backport to stable22 |
CarlSchwan
commented
Dec 17, 2021
MemberAuthor
/backport to stable21 |
This was referenced Dec 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only concerns subfolder and files inside a shared folder and is
used as fallback when the OCS api returns a empty result, because it
only works on the shared folder and not the content inside of it.
This unify the tab with the folder list.
This offers a less descriptive share information but making the
OCS api returns all the details even for the subfolder would very
probably be bad for performance (since we would need to fetch the shares
for all the parent folders until we found one or are in the root folder).
Signed-off-by: Carl Schwan carl@carlschwan.eu