Skip to content

DAV SEARCH: Expose upload_time and creation_time - #30366

Closed
marcelklehr wants to merge 2 commits into
masterfrom
feat/dav/creation-date
Closed

DAV SEARCH: Expose upload_time and creation_time#30366
marcelklehr wants to merge 2 commits into
masterfrom
feat/dav/creation-date

Conversation

@marcelklehr

@marcelklehrmarcelklehr commented Dec 21, 2021

Copy link
Copy Markdown
Member

fixes#21385

This would be very useful for nextcloud/photos#87

@marcelklehr
marcelklehr requested review from ChristophWurst, icewind1991 and juliusknorr and removed request for icewind1991December 21, 2021 12:39
@szaimenszaimen added this to the Nextcloud 24 milestone Dec 21, 2021
@szaimenszaimen added 3. to review Waiting for reviews enhancement labels Dec 21, 2021
@marcelklehr

Copy link
Copy Markdown
MemberAuthor

php-cs linter fails due to unrelated file lib/private/Files/ObjectStore/S3ConnectionTrait.php

@marcelklehr

Copy link
Copy Markdown
MemberAuthor

@icewind1991 Does Node#getFileInfo()->getCreationTime() return the file system creation time, or some value maintained in nextcloud? In my tests with this PR it always returns 0.

@szaimen

Copy link
Copy Markdown
Contributor

/rebase

@skjnldsvskjnldsv mentioned this pull request Mar 24, 2022
@blizzzblizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzzblizzz modified the milestones: Nextcloud 24, Nextcloud 25Apr 21, 2022
Comment threadapps/dav/lib/Connector/Sabre/FilesPlugin.php Outdated
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
@szaimen
szaimen requested a review from CarlSchwanApril 27, 2022 17:33
@CarlSchwan

Copy link
Copy Markdown
Member

Does Node#getFileInfo()->getCreationTime() return the file system creation time, or some value maintained in nextcloud? In my tests with this PR it always returns 0.

From that I understand the creation_time is set here:

if (isset($this->request->server['HTTP_X_OC_CTIME'])) {

So a client needs to send the time explicitly when uploading a file. Reading the desktop client source code, I can't find where this is set :(

@PVince81

Copy link
Copy Markdown
Member

maybe @mgallien for where the creation time is sent ?

@mgallien

Copy link
Copy Markdown
Contributor

maybe @mgallien for where the creation time is sent ?

my understanding is that desktop client only sets X-OC-Mtime and never any X-OC-Ctime

I confirm what @CarlSchwan said

@skjnldsvskjnldsv mentioned this pull request Aug 12, 2022
@skjnldsvskjnldsv mentioned this pull request Aug 18, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@ChristophWurst
ChristophWurst removed their request for review October 17, 2022 09:44
@szaimen

Copy link
Copy Markdown
Contributor

Hi everyone, what is needed to get this done? :)

@marcelklehr

Copy link
Copy Markdown
MemberAuthor

This was based on wrong assumptions

@ChristophWurst
ChristophWurst deleted the feat/dav/creation-date branch January 11, 2023 10:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload time and Creation time in searchrequest

7 participants

@marcelklehr@szaimen@CarlSchwan@PVince81@mgallien@juliusknorr@blizzz