Skip to content

Handle LocalServerException when scanning external shares - #30468

Merged
CarlSchwan merged 1 commit into
masterfrom
fix/handle-server-unavailable-scanner
Jan 9, 2022
Merged

Handle LocalServerException when scanning external shares#30468
CarlSchwan merged 1 commit into
masterfrom
fix/handle-server-unavailable-scanner

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

When remoteIsOwnCloud trows LocalServerException, the storage is
unavailable and instead of crashing the scanner, ignore the specific
storage.

Signed-off-by: Carl Schwan carl@carlschwan.eu

@CarlSchwanCarlSchwan added the 3. to review Waiting for reviews label Jan 3, 2022
@CarlSchwanCarlSchwan added this to the Nextcloud 24 milestone Jan 3, 2022
@CarlSchwan
CarlSchwan requested a review from a teamJanuary 3, 2022 08:19
@CarlSchwanCarlSchwan self-assigned this Jan 3, 2022
@CarlSchwan
CarlSchwan requested review from ArtificialOwl, come-nc and icewind1991 and removed request for a teamJanuary 3, 2022 08:19
@CarlSchwan

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@CarlSchwan

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@CarlSchwan

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

Comment threadapps/files_sharing/lib/External/Scanner.php Outdated
@CarlSchwan
CarlSchwanforce-pushed the fix/handle-server-unavailable-scanner branch from 57109a0 to 6fbf34aCompareJanuary 5, 2022 11:15
Comment threadapps/files_sharing/lib/External/Scanner.php
@CarlSchwan
CarlSchwanforce-pushed the fix/handle-server-unavailable-scanner branch from 6fbf34a to 56e2835CompareJanuary 5, 2022 17:23
Comment threadapps/files_sharing/lib/External/Scanner.php Outdated
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 6, 2022
@skjnldsv
skjnldsv self-requested a review January 6, 2022 16:39
When remoteIsOwnCloud trows LocalServerException, the storage is
unavailable and instead of crashing the scanner, ignore the specific
storage.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwanforce-pushed the fix/handle-server-unavailable-scanner branch from 56e2835 to 0b15da3CompareJanuary 6, 2022 17:03
@CarlSchwan

Copy link
Copy Markdown
MemberAuthor

Ci failure unrelated

@CarlSchwan
CarlSchwan merged commit 9824104 into masterJan 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan@nickvergessen@artonge@skjnldsv@szaimen