Uh oh!
There was an error while loading. Please reload this page.
Fix email verification - #30491
Merged
Merged
Conversation
Pytal
requested review from
PVince81, come-nc and skjnldsv
and removed request for
a teamJanuary 5, 2022 04:12
Pytal
commented
Jan 5, 2022
MemberAuthor
/backport to stable23 |
Pytal
commented
Jan 5, 2022
MemberAuthor
/backport to stable22 |
blizzz
commented
Jan 5, 2022
Member
can we have a unit test for this? |
Pytalforce-pushed
the
fix/30374/email-verification
branch
6 times, most recently
from
January 5, 2022 23:57
a9c26ae to
da95465Comparecome-nc
approved these changes
Jan 6, 2022
skjnldsv
approved these changes
Jan 6, 2022
Pytalforce-pushed
the
fix/30374/email-verification
branch
2 times, most recently
from
January 6, 2022 20:03
4b425b3 to
0fdba2cCompareSigned-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
fix/30374/email-verification
branch
from
January 6, 2022 23:47
0fdba2c to
19a3656ComparePytal
commented
Jan 7, 2022
MemberAuthor
Test updated and passing, would appreciate a re-review or another review now with the updated test :) |
blizzz
approved these changes
Jan 7, 2022
This was referenced Jan 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#30374