Uh oh!
There was an error while loading. Please reload this page.
fix: only use jquery once it is available - #30571
Merged
Merged
Conversation
publicpage.js is loaded very early and cannot rely on jquery being loaded already. Move the use of `$` into the `DomContentLoaded` handler. Signed-off-by: Azul <azul@riseup.net>
azul
commented
Jan 10, 2022
ContributorAuthor
Noticed this because cypress tests in text started failing complaining: This seems to be the easiest fix for now. Could also rewrite this without relying on jquery - but i guess that's for another time. |
artonge
approved these changes
Jan 10, 2022
artonge
commented
Jan 10, 2022
Collaborator
/rebase |
skjnldsv
approved these changes
Jan 10, 2022
solracsf
commented
Jan 10, 2022
Member
Backport? |
artonge
commented
Jan 11, 2022
Collaborator
/backport to stable23 |
artonge
commented
Jan 11, 2022
Collaborator
/backport to stable22 |
artonge
commented
Jan 11, 2022
Collaborator
/backport to stable21 |
The backport to stable21 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publicpage.js is loaded very early and cannot rely on jquery being loaded already.
Move the use of
$into theDomContentLoadedhandler.