Skip to content

Harden disk_free_space check in CheckSetupController - #30608

Merged
artonge merged 1 commit into
masterfrom
harden-fonct
Oct 10, 2022
Merged

Harden disk_free_space check in CheckSetupController#30608
artonge merged 1 commit into
masterfrom
harden-fonct

Conversation

@solracsf

@solracsfsolracsf commented Jan 11, 2022

Copy link
Copy Markdown
Member

To avoid things like #26034

@solracsfsolracsf added the 3. to review Waiting for reviews label Jan 11, 2022
@solracsf

solracsf commented Jan 11, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@solracsf

solracsf commented Jan 11, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@solracsf

solracsf commented Jan 11, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

CarlSchwan
CarlSchwan reviewed Jan 13, 2022
View reviewed changes
Comment threadapps/settings/lib/Controller/CheckSetupController.php
artonge
artonge reviewed Jan 13, 2022
View reviewed changes
Comment threadapps/settings/lib/Controller/CheckSetupController.php Outdated
@solracsfsolracsf changed the title Harden some PHP functions in CheckSetupControllerHarden disk_free_space check in CheckSetupControllerJan 20, 2022
@szaimen

szaimen commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

/rebase

@szaimenszaimen added this to the Nextcloud 24 milestone Apr 7, 2022
@szaimen

szaimen commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

@solracsf please fix dco and can you squash this? Thanks!

@blizzzblizzz mentioned this pull request Apr 13, 2022
Merged
@blizzzblizzz modified the milestones: Nextcloud 24, Nextcloud 25Apr 21, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
@blizzzblizzz mentioned this pull request Sep 6, 2022
Merged
@solracsf

solracsf commented Sep 6, 2022

Copy link
Copy Markdown
MemberAuthor

/rebase

@szaimen

szaimen commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

@solracsf please fix dco and can you squash this? Thanks!

Otherwise we cannot merge this...

@blizzzblizzz mentioned this pull request Sep 9, 2022
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
@blizzzblizzz mentioned this pull request Sep 20, 2022
Closed
@solracsfsolracsf closed this Oct 3, 2022
@solracsf
solracsf deleted the harden-fonct branch October 3, 2022 18:29
@artonge

artonge commented Oct 4, 2022

Copy link
Copy Markdown
Collaborator

Any reason this was closed @solracsf ?

@solracsf

solracsf commented Oct 4, 2022

Copy link
Copy Markdown
MemberAuthor

8 months and a simple squash blocking a PR...feel free to reopen, squash and merge.

@artonge
artonge restored the harden-fonct branch October 4, 2022 11:10
@artongeartonge reopened this Oct 4, 2022
@artonge
artongeforce-pushed the harden-fonct branch 2 times, most recently from 0d3f3fc to 717ec4bCompareOctober 4, 2022 11:21
@solracsf@artonge
Harden some PHP functions
4207b80
To avoid things like #26034
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artongeartonge self-assigned this Oct 4, 2022
@szaimen

szaimen commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

8 months and a simple squash blocking a PR...feel free to reopen, squash and merge.

The problem was mostly the missing DCO. Otherwise I would have done it for you.

szaimen
szaimen reviewed Oct 4, 2022
View reviewed changes
Comment threadapps/settings/lib/Controller/CheckSetupController.php
@artonge
artonge merged commit f456989 into masterOct 10, 2022
@artonge
artonge deleted the harden-fonct branch October 10, 2022 13:42
@artonge

artonge commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

/backport to stable25

@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 10, 2022

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 10, 2022

Copy link
Copy Markdown

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 10, 2022

Copy link
Copy Markdown

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 10, 2022

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@artonge

artonge commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

/backport to stable25

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Oct 10, 2022
Merged
@artonge

artonge commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

/backport to stable24

@artonge

artonge commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

/backport to stable23

This was referenced Oct 10, 2022
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaimenszaimenszaimen left review comments
@artongeartongeartonge approved these changes
@MichaIngMichaIngMichaIng approved these changes
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

@artongeartonge

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

6 participants

@solracsf@szaimen@artonge@CarlSchwan@MichaIng@blizzz