Skip to content

Fix loading of the text app in public shared links - #30719

Merged
julien-nc merged 1 commit into
masterfrom
fix/text-app-public-loading
Jan 17, 2022
Merged

Fix loading of the text app in public shared links#30719
julien-nc merged 1 commit into
masterfrom
fix/text-app-public-loading

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Jan 17, 2022

Copy link
Copy Markdown
Member

Instead of doing the centering for the entire public content, only do it
for the preview. This is more safe.

Signed-off-by: Carl Schwan carl@carlschwan.eu

@CarlSchwan
Fix loading of the text app in public shared links
d3d117c
Instead of doing the centering for the entire public content, only do it
for the preview. This is more safe.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwanCarlSchwan added this to the Nextcloud 24 milestone Jan 17, 2022
@CarlSchwan

CarlSchwan commented Jan 17, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@CarlSchwan

CarlSchwan commented Jan 17, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@CarlSchwan

CarlSchwan commented Jan 17, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

julien-nc
julien-nc approved these changes Jan 17, 2022
View reviewed changes

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

nickvergessen
nickvergessen approved these changes Jan 17, 2022
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading again, but there are still issues

@julien-nc

julien-nc commented Jan 17, 2022

Copy link
Copy Markdown
Member

@nickvergessen What kind of issues?

@julien-nc
julien-nc merged commit 3ea21d0 into masterJan 17, 2022
@julien-nc
julien-nc deleted the fix/text-app-public-loading branch January 17, 2022 18:00
@CarlSchwan

CarlSchwan commented Jan 17, 2022

Copy link
Copy Markdown
MemberAuthor

@nickvergessen What kind of issues?

The close button issue we already looked today in the call

@julien-nc

julien-nc commented Jan 17, 2022

Copy link
Copy Markdown
Member

@CarlSchwan Ok thanks. We're on it 😁.

This was referenced Jan 17, 2022
Merged
Closed
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 17, 2022

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

MichaIng pushed a commit that referenced this pull request Jan 17, 2022
Julien Veyssier@MichaIng
Merge pull request#30719from nextcloud/fix/text-app-public-loading
a9ea910
Fix loading of the text app in public shared links
@max-nextcloud

max-nextcloud commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

I don't think this needs to be backported to stable21. At least from what i saw cypress tests were still passing in stable21 - which indicates the problem probably did not exist there.

@CarlSchwan

CarlSchwan commented Jan 17, 2022

Copy link
Copy Markdown
MemberAuthor

Yeah, the problematic PR wasn't merged yet in stable21 due to merge conflict. And i'm probably just gonna close it

@max-nextcloud

max-nextcloud commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

#30696 is the backport pr in question.

@szaimenszaimen mentioned this pull request Feb 9, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@mejo-mejo-mejo- approved these changes
@julien-ncjulien-ncjulien-nc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

6 participants

@CarlSchwan@julien-nc@max-nextcloud@nickvergessen@mejo-@skjnldsv