Skip to content

Background job time windows - #30945

Merged
nickvergessen merged 3 commits into
masterfrom
techdebt/noid/background-job-time-windows
Feb 8, 2022
Merged

Background job time windows#30945
nickvergessen merged 3 commits into
masterfrom
techdebt/noid/background-job-time-windows

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jan 31, 2022•
edited
Loading

Copy link
Copy Markdown
Member
  • Should be used by background jobs which are rather heavy but are not time critical:
    • Background jobs in server code
    • Activity expiration
    • Suspicious login
    • Mail ?
    • Talk ?
  • Write documentation for app developers
  • Write documentation for sysadmins

@nickvergessennickvergessen added 2. developing Work in progress technical debt 🧱 🤔🚀 pending documentation This pull request needs an associated documentation update performance 🚀 labels Jan 31, 2022
@nickvergessennickvergessen added this to the Nextcloud 24 milestone Jan 31, 2022
nickvergessen
nickvergessen commented Jan 31, 2022
View reviewed changes
Comment threadconfig/config.sample.php Outdated
@PVince81PVince81 mentioned this pull request Feb 7, 2022
Closed
@PVince81

PVince81 commented Feb 7, 2022

Copy link
Copy Markdown
Member

@nickvergessen I've assigned you since you worked on this, let me know if you're not able to finish it and I can find someone else, let me know

it looks like the base work is already done, the decision/discussion for switching individual background jobs to the new mode could be done separately if needed

@nickvergessen

nickvergessen commented Feb 7, 2022

Copy link
Copy Markdown
MemberAuthor

I've assigned you since you worked on this, let me know if you're not able to finish it and I can find someone else, let me know

it looks like the base work is already done, the decision/discussion for switching individual background jobs to the new mode could be done separately if needed

Yes, it's basically done, just missing the developer documentation and a note in the upgrade guideline for admins

@nickvergessen
nickvergessen marked this pull request as ready for review February 7, 2022 12:53
@nickvergessennickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 7, 2022
@nickvergessen
Allow apps to specify if their background job can be delayed
b765f79
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Allow sysadmins to define a maintenance window where heavier jobs can…
3fd55cb
… run
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Use the new option to signaling insensitivity
b8e0a3d
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the techdebt/noid/background-job-time-windows branch from b4c40ef to b8e0a3dCompareFebruary 7, 2022 12:55
@nickvergessen

nickvergessen commented Feb 7, 2022

Copy link
Copy Markdown
MemberAuthor

Rebased and squashed

@nickvergessen
nickvergessen requested review from a team, CarlSchwan, PVince81, blizzz, icewind1991, juliusknorr and skjnldsv and removed request for a teamFebruary 7, 2022 12:55
ChristophWurst
ChristophWurst approved these changes Feb 7, 2022
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean :shipit:

@ChristophWurstChristophWurst mentioned this pull request Feb 7, 2022
Closed
6 tasks
miaulalala
miaulalala approved these changes Feb 7, 2022
View reviewed changes

@miaulalalamiaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@PVince81PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 7, 2022
@nickvergessennickvergessen mentioned this pull request Feb 7, 2022
Closed
9 tasks
@tcitworldtcitworld mentioned this pull request Feb 7, 2022
Merged
@szaimen

szaimen commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

Merge?

@nickvergessen
nickvergessen merged commit c58f8d6 into masterFeb 8, 2022
@nickvergessen
nickvergessen deleted the techdebt/noid/background-job-time-windows branch February 8, 2022 13:46
This was referenced Feb 10, 2022
Merged
Open
@AndyScherzinger

AndyScherzinger commented Feb 10, 2022

Copy link
Copy Markdown
Member

would also need backporting to v22 and up - cc @PVince81

@nickvergessennickvergessen mentioned this pull request Feb 11, 2022
Merged
@AndyScherzingerAndyScherzinger linked an issue Feb 15, 2022 that may be closed by this pull request
Timed-based background jobs #30273
Closed
@PVince81

PVince81 commented Feb 18, 2022

Copy link
Copy Markdown
Member

@nickvergessen can you update the docs for devs ?

This was referenced Feb 18, 2022
Closed
Closed
Closed
Closed
@juliusknorrjuliusknorr mentioned this pull request Feb 18, 2022
Closed
11 tasks
@nickvergessennickvergessen mentioned this pull request Feb 18, 2022
Closed
@nickvergessen

nickvergessen commented Feb 22, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 22, 2022
Merged
@nickvergessen

nickvergessen commented Feb 22, 2022

Copy link
Copy Markdown
MemberAuthor

can you update the docs for devs ?

nextcloud/documentation#8087

@juliusknorrjuliusknorr mentioned this pull request Mar 10, 2022
Closed
39 tasks
@pneuschwanderpneuschwander mentioned this pull request Apr 24, 2022
Closed
8 tasks
@nickvergessennickvergessen removed the pending documentation This pull request needs an associated documentation update label Nov 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@PVince81PVince81Awaiting requested review from PVince81
@blizzzblizzzAwaiting requested review from blizzz
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@icewind1991icewind1991Awaiting requested review from icewind1991
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

@nickvergessennickvergessen

Labels

4. to releaseReady to be released and/or waiting for tests to finishperformance 🚀technical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

Timed-based background jobs

6 participants

@nickvergessen@PVince81@szaimen@AndyScherzinger@ChristophWurst@miaulalala