Skip to content

Add OPcache recommendations to Transifex - #30950

Merged
PVince81 merged 1 commit into
masterfrom
enh/opcache-recommends-translation
Mar 24, 2022
Merged

Add OPcache recommendations to Transifex#30950
PVince81 merged 1 commit into
masterfrom
enh/opcache-recommends-translation

Conversation

@MichaIng

@MichaIngMichaIng commented Jan 31, 2022

Copy link
Copy Markdown
Member

Fixes: #30941

I went the most simple way for now, leaving HTML code and PHP settings in the string. Of course it could be moved into the parameters array as well, I'm open for suggestions on this.

The fallback word "currently" is currently not translated. We could make the equivalent word "now", part of circles app and NC client's Transifex, available to core and use it instead? Is there a way to declare a string globally instead of having to translate it per-app?

@MichaIngMichaIng added 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters php Pull requests that update Php code labels Jan 31, 2022
@MichaIngMichaIng added this to the Nextcloud 24 milestone Jan 31, 2022
Comment threadapps/settings/lib/Controller/CheckSetupController.php Outdated
@MichaIng

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@MichaIng

MichaIng commented Feb 19, 2022

Copy link
Copy Markdown
MemberAuthor

@MichaIng
MichaIngforce-pushed the enh/opcache-recommends-translation branch from 85dbfbc to bc91a05CompareMarch 4, 2022 00:27
@MichaIng
MichaIng requested a review from tcitworldMarch 11, 2022 18:56
@MichaIng
MichaIngforce-pushed the enh/opcache-recommends-translation branch from bc91a05 to 58e875aCompareMarch 16, 2022 21:28
@szaimen

Copy link
Copy Markdown
Contributor

/rebase

@nextcloud-command
nextcloud-commandforce-pushed the enh/opcache-recommends-translation branch from 58e875a to 13a27deCompareMarch 17, 2022 18:54
@MichaIng
MichaIngforce-pushed the enh/opcache-recommends-translation branch from 13a27de to ce810edCompareMarch 22, 2022 02:13
@szaimen

Copy link
Copy Markdown
Contributor

/rebase

Fixes: #30941
Signed-off-by: MichaIng <micha@dietpi.com>
@nextcloud-command
nextcloud-commandforce-pushed the enh/opcache-recommends-translation branch from ce810ed to 31606c9CompareMarch 22, 2022 10:43
@skjnldsvskjnldsv mentioned this pull request Mar 24, 2022

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
PVince81 merged commit 4511bd4 into masterMar 24, 2022
@PVince81
PVince81 deleted the enh/opcache-recommends-translation branch March 24, 2022 16:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: language/translations (l10n/i18n)Localization and translation mattersphpPull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[settings] There are no text strings in Transifex

10 participants

@MichaIng@szaimen@nickvergessen@PVince81@blizzz@tcitworld@artonge@CarlSchwan@Pytal@come-nc