Don't create cards_abiduri it if already exists

[artonge]

During migration from ownCloud, the cards_abiduri index is created but the addressbookid_uri_index index is not deleted. This leads to an error in this code path.

This PR make sure that we do not try to create the cards_abiduri index if it already exists and that the addressbookid_uri_index index is properly deleted.

Handy script to test the migration. Use it from a nextcloud root directory containing the migration.

#!/bin/bashset -eu
# Serving ownCloud then Nextcloud at localhost:8080# Username: admin# Password: admin
docker kill oc ||true
docker rm oc ||true
docker run \
--rm \
--name oc \
--detach \
--env OWNCLOUD_DOMAIN=localhost:8080 \
--publish 8080:8080 \
--volume /var/www/owncloud \
--volume "$PWD":/mnt/local \
owncloud/server:10.5
docker exec -it oc apt update
docker exec -it oc apt install -y nano rsync
docker exec -it oc sed -i '9,14d' /var/www/owncloud/config/config.php
docker exec -it oc occ app:enable oauth2
docker exec -it oc occ market:install calendar
docker exec -it oc occ app:enable configreport
docker exec -it oc cp /var/www/owncloud/config/config.php /var/www/config.php
instance=""read -rp "> Double press enter to start the migration." instance
docker exec -it oc rsync --delete --recursive --human-readable --exclude .git --exclude node_modules /mnt/local/ /var/www/owncloud
docker exec -it oc cp /var/www/config.php /var/www/owncloud/config/config.php
docker exec -it oc chown -R www-data:www-data /var/www/owncloud
docker exec -it oc occ upgrade -vvv ||true
occ db:convert-filecache-bigint
occ db:add-missing-columns
occ db:add-missing-indices
occ db:add-missing-primary-keys
# Use this command to copy your change in MigrateOauthTables.php to the docker container.# docker exec -it oc cp /mnt/local/lib/private/Repair/Owncloud/MigrateOauthTables.php /var/www/owncloud/lib/private/Repair/Owncloud/MigrateOauthTables.php

[artonge]

@julius, looks like you wrote the code.

Can you tell me why we use a foreach instead of renaming the index directly? I feel like I am missing something.

[artonge]

Oups, @juliushaertl

[artonge]

/rebase

[PVince81]

👍

[artonge]

/backport to stable23