Uh oh!
There was an error while loading. Please reload this page.
[stable22] Improve caching policy use immutable when loading versionned assets - #31243
Merged
Conversation
backportbot-nextcloudBot
requested review from
CarlSchwan, ChristophWurst, PVince81, Pytal, icewind1991, juliusknorr and solracsfFebruary 17, 2022 16:44
* Cache css with version in url. This makes most js and css requests to be cached by the browser * Force caching previews, the etag is in the url so that if the propfind gives a new etag, we will refresh it otherwise it's no use to try to fetch the new etag and do tons of DB queries Tested with firefox and 'debug' => false (important so that the js/css urls are generated with ?v= parameter) Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwanforce-pushed
the
backport/31141/stable22
branch
from
February 18, 2022 13:29
ba6a287 to
1da8fe5Comparejuliusknorr
approved these changes
Feb 21, 2022
juliusknorr
commented
Feb 21, 2022
Member
Conflicts seem to be resolved according to the diff. Mind to update the PR description then @CarlSchwan ? :) |
solracsf
approved these changes
Feb 23, 2022
solracsf
left a comment
Member
There was a problem hiding this comment.
It doesn't seem incomplete as per the diff 🤔 Maybe double-check @CarlSchwan 🍷
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #31141