Skip to content

[stable23] Run tests with primary object storage in CI + large upload fixes - #31453

Merged
blizzz merged 6 commits into
stable23from
s3-primary-ci-23
Apr 14, 2022
Merged

[stable23] Run tests with primary object storage in CI + large upload fixes#31453
blizzz merged 6 commits into
stable23from
s3-primary-ci-23

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Backport of test changes from #31266

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Mar 4, 2022
@icewind1991icewind1991 added this to the Nextcloud 23.0.4 milestone Mar 4, 2022
@PVince81PVince81 changed the title Run tests with primary object storage in CI[stable23] Run tests with primary object storage in CIMar 4, 2022
];
} else {
return null;
return [

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also backporting behavior changes?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell the previous behavior has never hit, as none of the code paths handle the null case.

Comment threadapps/dav/lib/Connector/Sabre/File.php
@PVince81PVince81 changed the title [stable23] Run tests with primary object storage in CI[stable23] Run tests with primary object storage in CI + large upload fixesMar 8, 2022

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

env:
MINIO_ACCESS_KEY: minio
MINIO_SECRET_KEY: minio123
image: bitnami/minio:2021.10.6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this run into limits due to the new docker hub policy?

@blizzz

Copy link
Copy Markdown
Member

/rebase

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…torage
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…g part files
Signed-off-by: Robin Appelman <robin@icewind.nl>
@blizzzblizzz mentioned this pull request Apr 13, 2022
@blizzz
blizzz merged commit ea3a9ba into stable23Apr 14, 2022
@blizzz
blizzz deleted the s3-primary-ci-23 branch April 14, 2022 11:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991@blizzz@PVince81@szaimen