Uh oh!
There was an error while loading. Please reload this page.
Fix occ user:add-app-password - #31519
Merged
Merged
Conversation
…n app password Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
CarlSchwan, ChristophWurst, PVince81, SMillerDev, julien-nc and vitormattosMarch 10, 2022 14:32
Uh oh!
There was an error while loading. Please reload this page.
SMillerDev
left a comment
Contributor
There was a problem hiding this comment.
LGTM but then I thought the original implementation was fine too 😅
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
bugfix/noid/fix-occ-user-add-apppassword
branch
from
March 10, 2022 14:52
137b633 to
50ccf7eCompareCarlSchwan
approved these changes
Mar 10, 2022
PVince81
commented
Mar 11, 2022
Member
/backport to stable23 |
PVince81
commented
Mar 11, 2022
Member
/backport to stable22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps
Create an app-password via all 3 methods and check the differences: