Skip to content

do not forget DB table prefix with truncate query - #31620

Merged
PVince81 merged 1 commit into
masterfrom
fix/noid/truncate-oracle
Mar 22, 2022
Merged

do not forget DB table prefix with truncate query#31620
PVince81 merged 1 commit into
masterfrom
fix/noid/truncate-oracle

Conversation

@blizzz

@blizzzblizzz commented Mar 18, 2022

Copy link
Copy Markdown
Member
  • as used in LDAP's AbstractMapping::clear() method
  • and in Comment's ManagerTest::setUp()
  • fixes a DB Exception with Oracle

@blizzz
do not forget DB table prefix with truncate query
4656753
- as used in LDAP's AbstractMapping::clear() method
- and in Comment's ManagerTest::setUp()
- fixes a DB Exception with Oracle
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 24 milestone Mar 18, 2022
@blizzz
blizzz requested review from a team, PVince81, come-nc and nickvergessen and removed request for a teamMarch 18, 2022 16:04
@come-nc

come-nc commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

How does one know when PREFIX is needed and when not?
We have other calls on the IDBConnection that do not contain it:
https://github.com/nextcloud/server/blob/master/apps/user_ldap/lib/Migration/Version1130Date20211102154716.php#L184

@blizzz

blizzz commented Mar 21, 2022

Copy link
Copy Markdown
MemberAuthor

How does one know when PREFIX is needed and when not? We have other calls on the IDBConnection that do not contain it: https://github.com/nextcloud/server/blob/master/apps/user_ldap/lib/Migration/Version1130Date20211102154716.php#L184

It is not needed when using the query builder.

nickvergessen
nickvergessen approved these changes Mar 21, 2022
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doc block thou 🤪

Maybe we fix that properly?

@PVince81
PVince81 merged commit 6fa51be into masterMar 22, 2022
@PVince81
PVince81 deleted the fix/noid/truncate-oracle branch March 22, 2022 09:46
@blizzz

This comment was marked as resolved.

Sign in to view
@blizzz

This comment was marked as duplicate.

Sign in to view
@blizzz

blizzz commented Mar 22, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@blizzz

blizzz commented Mar 22, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@backportbot-nextcloud

This comment was marked as duplicate.

Sign in to view
@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 22, 2022

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 22, 2022

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@blizzz

blizzz commented Mar 22, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 22, 2022
Merged
@blizzz

This comment was marked as duplicate.

Sign in to view
@blizzz

This comment was marked as duplicate.

Sign in to view
@blizzz

This comment was marked as duplicate.

Sign in to view
@backportbot-nextcloud

This comment was marked as duplicate.

Sign in to view
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@blizzz

blizzz commented Mar 22, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 22, 2022
Merged
@blizzz

blizzz commented Mar 22, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@blizzz

This comment was marked as duplicate.

Sign in to view
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 22, 2022
Merged
@backportbot-nextcloud

This comment was marked as duplicate.

Sign in to view
@blizzz

blizzz commented Mar 23, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 23, 2022

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@blizzzblizzz mentioned this pull request Mar 23, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@come-nccome-nccome-nc approved these changes
@PVince81PVince81Awaiting requested review from PVince81

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

5 participants

@blizzz@come-nc@nickvergessen@PVince81@skjnldsv