Skip to content

[stable23] Toggle profile globally - #31624

Merged
Pytal merged 2 commits into
stable23from
backport/29372/stable23
Mar 25, 2022
Merged

[stable23] Toggle profile globally#31624
Pytal merged 2 commits into
stable23from
backport/29372/stable23

Conversation

@Pytal

@PytalPytal commented Mar 19, 2022

Copy link
Copy Markdown
Member

Backport of #29372

@PytalPytal added enhancement 3. to review Waiting for reviews feature: settings feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Mar 19, 2022
@PytalPytal added this to the Nextcloud 23.0.4 milestone Mar 19, 2022
@Pytal
Pytal requested review from a team, artonge and szaimenMarch 19, 2022 00:47
@PytalPytal self-assigned this Mar 19, 2022
@Pytal
Pytal requested review from CarlSchwan, PVince81 and skjnldsv and removed request for a teamMarch 19, 2022 00:47
@PytalPytal mentioned this pull request Mar 19, 2022
Merged
@szaimen

szaimen commented Mar 19, 2022

Copy link
Copy Markdown
Contributor

Is it expected that this changes much less files and code than in NC24? I didn't try it out but could do so...

@artonge

artonge commented Mar 21, 2022

Copy link
Copy Markdown
Collaborator

Is it expected that this changes much less files and code than in NC24? I didn't try it out but could do so...

It's due to the changes we did on the frontend files bundling. The 24 PR changes all the output files, and this PR only changes the settings output files. So way less files.

It should be good :)

@szaimen

szaimen commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

/rebase

@Pytal
Pytal requested a review from a teamMarch 21, 2022 19:41
@PytalPytal mentioned this pull request Mar 22, 2022
Merged
@szaimenszaimen mentioned this pull request Mar 24, 2022
Merged
PVince81
PVince81 approved these changes Mar 24, 2022
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pytal
Pytalforce-pushed the backport/29372/stable23 branch from dc5268b to f08c3b3CompareMarch 24, 2022 16:14
@Pytal

Pytal commented Mar 24, 2022

Copy link
Copy Markdown
MemberAuthor

Triggered CI rerun

@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2022
@Pytal
Pytalforce-pushed the backport/29372/stable23 branch from f08c3b3 to 255ba13CompareMarch 24, 2022 18:21
Pytal added 2 commits March 25, 2022 03:53
@Pytal
Add global profile toggle config
8bef2ec
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 1fc0b43)
@Pytal
Add profile default setting for admin
d8c0446
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 108abd7)
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the backport/29372/stable23 branch from 255ba13 to d8c0446CompareMarch 25, 2022 03:54
@Pytal

Pytal commented Mar 25, 2022

Copy link
Copy Markdown
MemberAuthor

CI failure unrelated

@Pytal
Pytal merged commit fea072c into stable23Mar 25, 2022
@Pytal
Pytal deleted the backport/29372/stable23 branch March 25, 2022 05:26
@szaimenszaimen mentioned this pull request Mar 28, 2022
Closed
@blizzzblizzz mentioned this pull request Apr 13, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@szaimenszaimenszaimen approved these changes
@artongeartongeAwaiting requested review from artonge
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: profilePRs or issues related to the Profile feature (e.g. Profile page, API, etc.)feature: settings

Projects

None yet

Milestone

Nextcloud 23.0.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Pytal@szaimen@artonge@PVince81