Skip to content

Use correct theming when returning the defaults - #3163

Merged
LukasReschke merged 1 commit into
masterfrom
issue-3148-wrong-page-title-on-non-nonce-browser
Jan 26, 2017
Merged

Use correct theming when returning the defaults#3163
LukasReschke merged 1 commit into
masterfrom
issue-3148-wrong-page-title-on-non-nonce-browser

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Fix#3148

To test with firefox/chrome, just remove the following lines:

Request::USER_AGENT_CHROME,
// Firefox 45+
'/^Mozilla\/5\.0 \([^)]+\) Gecko\/[0-9.]+ Firefox\/(4[5-9]|[5-9][0-9])\.[0-9.]+$/',

cc @LukasReschke@MorrisJobke

Should backport to 11

Signed-off-by: Joas Schilling <coding@schilljs.com>

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke

Copy link
Copy Markdown
Member

@LukasReschke
LukasReschke merged commit 43315e2 into masterJan 26, 2017
@LukasReschke
LukasReschke deleted the issue-3148-wrong-page-title-on-non-nonce-browser branch January 26, 2017 17:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@MorrisJobke@LukasReschke