Skip to content

[stable23] improve imagick, bcmath and gmp extension warnings - #31634

Merged
blizzz merged 2 commits into
stable23from
backport/31470/stable23
Apr 14, 2022
Merged

[stable23] improve imagick, bcmath and gmp extension warnings#31634
blizzz merged 2 commits into
stable23from
backport/31470/stable23

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #31470

@szaimen

Copy link
Copy Markdown
Contributor

/rebase

@MichaIng

Copy link
Copy Markdown
Member

/rebase

@MichaIng

Copy link
Copy Markdown
Member

Drone failure is unrelated.

@szaimen

szaimen commented Mar 31, 2022

Copy link
Copy Markdown
Contributor
The autoloaders are not up to date
--
Please run: bash build/autoloaderchecker.sh
And commit the result

@MichaIng

Copy link
Copy Markdown
Member

@szaimen
Where can this annotation be found? I just see the expectedly failing Samba Drone test.

@szaimen

Copy link
Copy Markdown
Contributor

image

@MichaIng

Copy link
Copy Markdown
Member

Okay, autoloaders updated. However, to me it looks like it is completely unrelated to this PR. But the (many) changes look good.

Strange is now that Node workflows fail due to package(-lock).json being out of sync. No idea how updating (PHP) autoloaders can affect the untouched Node dependencies 🤔.

@MichaIng

MichaIng commented Apr 2, 2022

Copy link
Copy Markdown
Member

Ah, indeed the Node failures are unrelated, some on all other recent stable23 base branch PRs, e.g.: #31788

I can try to fix it, but I think this should be better solved in a dedicated PR. I could also revert the autoloaders update and apply this in a separate PR.

@szaimen

szaimen commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

I can try to fix it, but I think this should be better solved in a dedicated PR. I could also revert the autoloaders update and apply this in a separate PR.

sounds good to me, thanks!👍

@MichaIng

Copy link
Copy Markdown
Member

sounds good to me, thanks!👍

Which of the 3 options? 😄
I think I'll just open new PRs to fix the unrelated issues, including the autoloader update.

@szaimen

Copy link
Copy Markdown
Contributor

I think I'll just open new PRs to fix the unrelated issues, including the autoloader update.

Yes, this one is what I meant. Sry! :)

@MichaIng

MichaIng commented Apr 6, 2022

Copy link
Copy Markdown
Member

@blizzzblizzz mentioned this pull request Apr 13, 2022
@blizzzblizzz added the 2. developing Work in progress label Apr 14, 2022
@blizzz

blizzz commented Apr 14, 2022

Copy link
Copy Markdown
Member

manual rebase is necessary

szaimenand others added 2 commits April 14, 2022 13:29
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
@MichaIng
MichaIngforce-pushed the backport/31470/stable23 branch from 2c860f0 to 9e3b089CompareApril 14, 2022 11:31
@MichaIng

Copy link
Copy Markdown
Member

Done

@MichaIngMichaIng added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 14, 2022
@blizzz

Copy link
Copy Markdown
Member

Drone CI was green (apart of Samba failing for other reasons)

@blizzz
blizzz merged commit e5c6de3 into stable23Apr 14, 2022
@blizzz
blizzz deleted the backport/31470/stable23 branch April 14, 2022 20:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@szaimen@MichaIng@blizzz@Pytal