Skip to content

Automatically cut the token name on the first level - #31688

Merged
nickvergessen merged 2 commits into
masterfrom
bugfix/31658/automatically-cut-the-token-name-on-first-level
Mar 24, 2022
Merged

Automatically cut the token name on the first level#31688
nickvergessen merged 2 commits into
masterfrom
bugfix/31658/automatically-cut-the-token-name-on-first-level

Conversation

@nickvergessen

@nickvergessennickvergessen commented Mar 23, 2022

Copy link
Copy Markdown
Member

Follow up to #31658

@nickvergessen
Automatically cut the token name on the first level
d683e0d
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Remove old shortening
5f75d2e
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added this to the Nextcloud 24 milestone Mar 23, 2022
This was referenced Mar 23, 2022
Merged
Merged
Merged
max-nextcloud
max-nextcloud reviewed Mar 23, 2022
View reviewed changes

@max-nextcloudmax-nextcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes the failing cypress runs in text. I do not (yet) understand the implications of these changes. Mainly wondering if truncated names will always be unique. But i won't be able to think this through tonight. So just commenting and not approving.

@nickvergessen

nickvergessen commented Mar 23, 2022

Copy link
Copy Markdown
MemberAuthor

Backports added to:

@nickvergessen

nickvergessen commented Mar 24, 2022

Copy link
Copy Markdown
MemberAuthor

Mainly wondering if truncated names will always be unique.

It's just the labels shown in the list of index.php/settings/user/security
They are not unique, e.g. every token created with occ user:add-app-password is called "cli"

max-nextcloud
max-nextcloud approved these changes Mar 24, 2022
View reviewed changes

@max-nextcloudmax-nextcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay... since the name is just for identifying the source of the token and tokens are not identified by it this seems save to me.

@nickvergessen
nickvergessen merged commit c9ea236 into masterMar 24, 2022
@nickvergessen
nickvergessen deleted the bugfix/31658/automatically-cut-the-token-name-on-first-level branch March 24, 2022 09:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@max-nextcloudmax-nextcloudmax-nextcloud approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991
@miaulalalamiaulalalaAwaiting requested review from miaulalala

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: authenticationregression

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@ChristophWurst@max-nextcloud