Uh oh!
There was an error while loading. Please reload this page.
[stable23] Fix incorrect if conditions in View - #31878
Merged
Merged
Conversation
come-nc
requested review from
a team, blizzz, icewind1991 and juliusknorr
and removed request for
a teamApril 7, 2022 13:39
come-nc
commented
Apr 7, 2022
ContributorAuthor
/backport to stable22 |
artonge
approved these changes
Apr 7, 2022
blizzz
approved these changes
Apr 13, 2022
blizzz
commented
Apr 13, 2022
Member
/rebase |
Merged
($something->getPermissions() && Constants::PERMISSION_READ) does not make sense as PERMISSION_READ contant is 1 this will always evaluate to true. getPersmissions is returning an int which is a bitwise combination as documented in the interface, so it should be used with bit operators. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
artongeforce-pushed
the
backport/31754/stable23
branch
from
April 14, 2022 09:06
487e06b to
aef9ba2Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #31754
Only backported the fix itself as the other commit did not apply