Skip to content

Fix #3174 - #3190

Merged
skjnldsv merged 1 commit into
masterfrom
fix-sharing-popover
Jan 22, 2017
Merged

Fix #3174#3190
skjnldsv merged 1 commit into
masterfrom
fix-sharing-popover

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jan 21, 2017•
edited by MorrisJobke
Loading

Copy link
Copy Markdown
Member

A small misalignment because it's best with #3187
And:

  • Prepared for the new inputs.scss
  • Fit popover to guidelines
  • Fixed some css

@skjnldsv
Fix#3174
f40e5b7
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added 3. to review Waiting for reviews design Design, UI, UX, etc. feature: scss labels Jan 21, 2017
@skjnldsvskjnldsv added this to the Nextcloud 12.0 milestone Jan 21, 2017
@skjnldsvskjnldsv self-assigned this Jan 21, 2017
@mention-bot

mention-bot commented Jan 21, 2017

Copy link
Copy Markdown

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @jancborchardt and @ChristophWurst to be potential reviewers.

MorrisJobke
MorrisJobke approved these changes Jan 21, 2017
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍
bildschirmfoto 2017-01-21 um 16 54 20

@skjnldsv

skjnldsv commented Jan 22, 2017

Copy link
Copy Markdown
MemberAuthor

@LukasReschke quick one :)

@skjnldsv
skjnldsv merged commit 7eec5e0 into masterJan 22, 2017
@skjnldsv
skjnldsv deleted the fix-sharing-popover branch January 22, 2017 19:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@LukasReschkeLukasReschkeLukasReschke approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@blizzzblizzzAwaiting requested review from blizzz

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.feature: scss

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

Unshare menu has too high line-height

4 participants

@skjnldsv@mention-bot@MorrisJobke@LukasReschke