Uh oh!
There was an error while loading. Please reload this page.
NA - #31904
Closed
AndyXheli wants to merge 8 commits into
Closed
Conversation
AndyXheli
commented
Apr 8, 2022
ContributorAuthor
Thank you very much!! :) |
szaimen
reviewed
Apr 8, 2022
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Andrea Xheli axheli@axtsolutions.com
AndyXheli
commented
Apr 8, 2022
ContributorAuthor
Just updated it with them removed. |
ContributorAuthor
Should we also backport this ? |
szaimen
requested changes
Apr 8, 2022
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Andrea Xheli axheli@axtsolutions.com
szaimen
commented
Apr 8, 2022
Contributor
@AndyXheli can you please fix DCO and squash your commits? Afterwards we can merge :) |
Signed-off-by: Andrea Xheli axheli@axtsolutions.com Signed-off-by: Andy Xheli <axheli@SWCD.CAD.SYSTEM>
Signed-off-by: Andrea Xheli axheli@axtsolutions.com Signed-off-by: Andy Xheli <axheli@SWCD.CAD.SYSTEM>
AndyXheli
commented
Apr 8, 2022
ContributorAuthor
@szaimen I'm sorry can you please help me. I have no idea what I did. I apologies :( |
szaimen
commented
Apr 8, 2022
Contributor
In this case just open a new PR with this bugfix in a single commit and don't forget the sign-off ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrea Xheli axheli@axtsolutions.com
Should fix LDAP AD Integration Dark Theme issue #25809
Updated code Ref Fix LDAP Dark Theme Issue #26666
Before
After Dark Theme
After Normal Theme
