Skip to content

Fix LDAP Dark Theme Issue - #31908

Merged
szaimen merged 1 commit into
nextcloud:masterfrom
AndyXheli:patch-2
Apr 8, 2022
Merged

Fix LDAP Dark Theme Issue#31908
szaimen merged 1 commit into
nextcloud:masterfrom
AndyXheli:patch-2

Conversation

@AndyXheli

@AndyXheliAndyXheli commented Apr 8, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Andy Xheli axheli@axtsolutions.com

Should fix LDAP AD Integration Dark Theme issue #25809

Before
image

After Dark Theme
image

After Normal Theme
image

@AndyXheli

AndyXheli commented Apr 8, 2022

Copy link
Copy Markdown
ContributorAuthor

@szaimen How about now. I did add the signed off

@szaimen

szaimen commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

good enough for me 👍
DCO expect it in a bit different form but not a problem in my opinion.

@szaimenszaimen added bug 3. to review Waiting for reviews labels Apr 8, 2022
@szaimenszaimen added this to the Nextcloud 24 milestone Apr 8, 2022
@szaimen
szaimen requested review from a team, skjnldsv, st3iny, szaimen and vanpertsch and removed request for a teamApril 8, 2022 16:59
@AndyXheli

AndyXheli commented Apr 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Cool Sounds good with me. am i suppose to type in differently or missing something ? so i can correct it in the future ?

@szaimen

szaimen commented Apr 8, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Cool Sounds good with me. am i suppose to type in differently or missing something ? so i can correct it in the future ?

For the future, the sign-off needs to be in this exakt form:
Signed-off-by: Random J Developer <random@developer.example.org>
(don't forget the opening and closing char around the mail-address)

@AndyXheli

AndyXheli commented Apr 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Ops 🤦🏻‍♂️ thank you so much!!

@szaimen
szaimen requested review from CarlSchwan and PytalApril 8, 2022 17:04
@AndyXheliAndyXheli mentioned this pull request Apr 8, 2022
Closed
@szaimenszaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 8, 2022
Andy Xheli@szaimen
Fix LDAP Dark Theme Issue
64f75ed
Signed-off-by: Andy Xheli axheli@axtsolutions.com
@szaimen

szaimen commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

s3 failure unrelated

@szaimen
szaimen merged commit fadad1e into nextcloud:masterApr 8, 2022
@welcome

welcomeBot commented Apr 8, 2022

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@AndyXheli
AndyXheli deleted the patch-2 branch April 8, 2022 21:31
@blizzzblizzz mentioned this pull request Apr 13, 2022
Merged
@AndyXheli

AndyXheli commented Apr 13, 2022

Copy link
Copy Markdown
ContributorAuthor

@szaimen is it too late to also backport this to NC23 ?

@szaimen

szaimen commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

Yes, at least too late for the next 23 release

@szaimen

szaimen commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

/backport to stable23

@szaimen

szaimen commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

/backport to stable22

This was referenced Apr 13, 2022
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PytalPytalPytal approved these changes
@szaimenszaimenszaimen approved these changes
@st3inyst3inyAwaiting requested review from st3iny
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@vanpertschvanpertschAwaiting requested review from vanpertsch
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

4 participants

@AndyXheli@szaimen@Pytal@skjnldsv