Skip to content

Fix accept/reject remote share action #31301 - #31910

Merged
szaimen merged 1 commit into
nextcloud:masterfrom
MSe1969:master
Apr 12, 2022
Merged

Fix accept/reject remote share action #31301#31910
szaimen merged 1 commit into
nextcloud:masterfrom
MSe1969:master

Conversation

@MSe1969

@MSe1969MSe1969 commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

This is the fix for the described problem in
#31301

@szaimenszaimen added bug 3. to review Waiting for reviews labels Apr 8, 2022
@szaimenszaimen added this to the Nextcloud 24 milestone Apr 8, 2022
@szaimen

szaimen commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

@MSe1969 thanks for fixing this!

Can you please solve DCO? Thank you! :)

@MSe1969

MSe1969 commented Apr 8, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@MSe1969 thanks for fixing this!

Can you please solve DCO? Thank you! :)

Done.

@szaimen

szaimen commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

Thank you! :)

@szaimen
szaimen requested review from a team, PVince81, Pytal, artonge and nickvergessen and removed request for a teamApril 8, 2022 21:23
szaimen
szaimen reviewed Apr 8, 2022
View reviewed changes
Comment threadapps/files_sharing/js/app.js Outdated
szaimen
szaimen reviewed Apr 8, 2022
View reviewed changes
Comment threadapps/files_sharing/js/app.js Outdated
@nickvergessen
nickvergessen removed their request for review April 8, 2022 21:26
@szaimen

szaimen commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

Looks good to me :)
@MSe1969 can you please rebase, compile the js and push it to this branch? Then CI should be green :)

szaimen
szaimen approved these changes Apr 12, 2022
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me but didn't test

@MSe1969

MSe1969 commented Apr 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Question:
As this would also apply to the current stable version 23 - will you centrally take care about that or do I need to also make the same PR against the stable23 branch?

@szaimen

szaimen commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

Question: As this would also apply to the current stable version 23 - will you centrally take care about that or do I need to also make the same PR against the stable23 branch?

we can use the backport bot to do this after it got merged :)

@MSe1969@szaimen
Fix accept/reject remote share action
8a6bfcb
This is the fix for the described problem in
#31301
Signed-off-by: MSe1969 <mse1969@posteo.de>
@szaimenszaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 12, 2022
@szaimen

szaimen commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

Failure is unrelated

@szaimen
szaimen merged commit df14579 into nextcloud:masterApr 12, 2022
@welcome

welcomeBot commented Apr 12, 2022

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@szaimen

szaimen commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

/backport to stable23

@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 12, 2022

Copy link
Copy Markdown

The backport to stable23 failed. Please do this backport manually.

@szaimenszaimen mentioned this pull request Apr 12, 2022
Merged
@szaimen

szaimen commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

#31949

This was referenced Apr 13, 2022
Merged
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@PytalPytalPytal approved these changes
@szaimenszaimenszaimen approved these changes
@PVince81PVince81Awaiting requested review from PVince81
@artongeartongeAwaiting requested review from artonge

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

5 participants

@MSe1969@szaimen@nickvergessen@Pytal@skjnldsv