Uh oh!
There was an error while loading. Please reload this page.
Use stored user for PasswordUpdatedEvent - #32016
Merged
Merged
Conversation
artonge
requested review from
CarlSchwan, icewind1991 and vanpertsch
and removed request for
a teamApril 19, 2022 13:58
artongeforce-pushed
the
fix/PasswordUpdatedEvent_handling
branch
2 times, most recently
from
April 20, 2022 12:03
3268622 to
ad22d14Comparecome-nc
approved these changes
Apr 28, 2022
come-nc
reviewed
Apr 28, 2022
Uh oh!
There was an error while loading. Please reload this page.
artongeforce-pushed
the
fix/PasswordUpdatedEvent_handling
branch
3 times, most recently
from
April 28, 2022 15:31
627f950 to
8517bb2Compareartonge
commented
May 2, 2022
CollaboratorAuthor
/rebase |
artongeforce-pushed
the
fix/PasswordUpdatedEvent_handling
branch
from
May 3, 2022 16:06
8517bb2 to
290697bCompareartongeforce-pushed
the
fix/PasswordUpdatedEvent_handling
branch
3 times, most recently
from
May 10, 2022 09:20
2b9d29f to
498681cCompareWhen handling PasswordUpdatedEvent event, we are calling getLoginName which does not exists. This PR adds a condition to use the previously stored user when handling PasswordUpdatedEvent. Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
fix/PasswordUpdatedEvent_handling
branch
from
May 10, 2022 10:16
498681c to
816e782Compareartonge
commented
May 10, 2022
CollaboratorAuthor
CI failure unrelated, samba is always failing https://github.com/nextcloud/server/actions/workflows/smb-kerberos.yml |
artonge
commented
May 16, 2022
CollaboratorAuthor
Review ping :) |
CarlSchwan
approved these changes
May 16, 2022
blizzz
commented
Jun 22, 2022
Member
/backport to stable24 |
blizzz
commented
Jun 22, 2022
Member
/backport to stable23 |
blizzz
commented
Jun 22, 2022
Member
/backport to stable22 |
This was referenced Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handling
PasswordUpdatedEventevent, we are callinggetLoginNamewhich does not exist.This PR adds a condition to use the previously stored user when handling
PasswordUpdatedEvent.