Skip to content

Start porting Admin audit to new events - #32019

Closed
CarlSchwan wants to merge 1 commit into
masterfrom
cleanup/event/admin_audit
Closed

Start porting Admin audit to new events#32019
CarlSchwan wants to merge 1 commit into
masterfrom
cleanup/event/admin_audit

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Apr 19, 2022

Copy link
Copy Markdown
Member

No description provided.

@CarlSchwanCarlSchwan self-assigned this Apr 19, 2022
@CarlSchwanCarlSchwan added this to the Nextcloud 25 milestone Apr 19, 2022
@CarlSchwan
CarlSchwanforce-pushed the cleanup/event/admin_audit branch from d997c8b to ec11322CompareApril 19, 2022 19:03
nickvergessen
nickvergessen reviewed Apr 20, 2022
View reviewed changes
Comment threadapps/admin_audit/lib/Actions/Auth.php Outdated
nickvergessen
nickvergessen reviewed Apr 20, 2022
View reviewed changes
Comment threadapps/user_ldap/lib/Jobs/Sync.php Outdated
@CarlSchwan
CarlSchwanforce-pushed the cleanup/event/admin_audit branch from ec11322 to fe22b7fCompareApril 22, 2022 13:26
nickvergessen
nickvergessen reviewed Apr 25, 2022
View reviewed changes
Comment threadapps/user_ldap/lib/Jobs/Sync.php Outdated
@CarlSchwanCarlSchwan mentioned this pull request Apr 25, 2022
Open
7 tasks
@CarlSchwan
CarlSchwanforce-pushed the cleanup/event/admin_audit branch from fe22b7f to 6066303CompareApril 25, 2022 15:14
nickvergessen
nickvergessen requested changes Apr 25, 2022
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or am I missing something?

Comment threadapps/user_ldap/lib/Jobs/Sync.php Outdated
Comment threadapps/user_ldap/lib/Jobs/Sync.php Outdated
@CarlSchwanCarlSchwan added the 2. developing Work in progress label Apr 25, 2022
@CarlSchwan
CarlSchwanforce-pushed the cleanup/event/admin_audit branch from 6066303 to f460155CompareApril 25, 2022 16:40
@CarlSchwan
CarlSchwanforce-pushed the cleanup/event/admin_audit branch from f460155 to ad4fe1cCompareApril 25, 2022 16:54
nickvergessen
nickvergessen approved these changes Apr 26, 2022
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half 🐘

come-nc
come-nc reviewed Apr 26, 2022
View reviewed changes
Comment threadapps/user_ldap/ajax/clearMappings.php Outdated
Comment threadapps/admin_audit/lib/Actions/UserManagement.php Outdated
Comment threadapps/user_ldap/lib/Jobs/Sync.php Outdated
Comment threadapps/user_ldap/lib/Jobs/Sync.php
Comment threadapps/user_ldap/lib/Mapping/AbstractMapping.php Outdated
Comment threadlib/composer/composer/autoload_classmap.php
Comment threadlib/public/User/Events/BeforeUserIdUnassignedEvent.php Outdated
Comment threadlib/public/User/Events/BeforeUserIdUnassignedEvent.php Outdated
blizzz
blizzz reviewed Apr 26, 2022
View reviewed changes

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions

Comment threadapps/admin_audit/lib/Actions/GroupManagement.php Outdated
Comment threadapps/admin_audit/lib/Actions/UserManagement.php Outdated
@CarlSchwan
CarlSchwanforce-pushed the cleanup/event/admin_audit branch 2 times, most recently from 291eb93 to e6e6a95CompareMay 5, 2022 19:57
come-nc
come-nc reviewed May 24, 2022
View reviewed changes
Comment threadapps/admin_audit/lib/Actions/GroupManagement.php Outdated
Comment threadapps/admin_audit/lib/Actions/UserManagement.php Outdated
@CarlSchwanCarlSchwan added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 21, 2022
@CarlSchwan
Start porting Admin audit to new events
3f118f9
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwanforce-pushed the cleanup/event/admin_audit branch from 9a9326b to 3f118f9CompareJune 21, 2022 10:05
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jun 21, 2022
View reviewed changes
Comment threadapps/user_ldap/lib/Jobs/Sync.php

/**
* determines the next configuration prefix based on the last one (if any)
*

Check notice

Code scanning / Psalm

PossiblyNullOperand

Right operand cannot be nullable, got mixed|null
Comment threadapps/user_ldap/lib/Proxy.php
$coreUserManager, $coreNotificationManager, $shareManager);
$connector = new Connection($this->ldap, $configPrefix);
$access = new Access($connector, $this->ldap, $userManager, new Helper($ocConfig, \OC::$server->getDatabaseConnection()), $ocConfig, $coreUserManager, $logger);
$access = new Access($connector, $this->ldap, $userManager, new Helper($ocConfig, \OC::$server->getDatabaseConnection()), $ocConfig, $coreUserManager, $logger, $dispatcher);

Check notice

Code scanning / Psalm

PossiblyUndefinedVariable

Possibly undefined variable $dispatcher, first seen on line 87
blizzz
blizzz requested changes Jun 24, 2022
View reviewed changes
Comment threadapps/user_ldap/lib/Proxy.php
$coreNotificationManager = \OC::$server->getNotificationManager();
$shareManager = \OC::$server->get(IManager::class);
$logger = \OC::$server->get(LoggerInterface::class);
$dispatcher = \OC::$server->get(IEventDispatcher::class);

@blizzzblizzzJun 24, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make $dispatcher static, otherwise it will be null on the next runs.

@come-nccome-ncJun 27, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Is that specific to IEventDispatcher?

@blizzzblizzzJun 27, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the local var, look couple lines above

@come-nccome-ncJun 27, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok understood, nice catch.

This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@come-nccome-nc assigned come-nc and unassigned CarlSchwanJan 24, 2023
@come-nccome-nc added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 24, 2023
@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 7, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
@come-nccome-nc mentioned this pull request Mar 13, 2023
Closed
5 tasks
tcitworld pushed a commit that referenced this pull request Mar 13, 2023
@CarlSchwan@tcitworld
Introduce user id assigned typed events for LDAP usage
eaa6c70
Based on work from #32019
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld

tcitworld commented Mar 13, 2023

Copy link
Copy Markdown
Member

I've pulled most of this in #37193, apart from the heavier refactoring from AbstractMapping that isn't related.

tcitworld pushed a commit that referenced this pull request Mar 13, 2023
@CarlSchwan@tcitworld
Introduce user id assigned typed events for LDAP usage
fc47793
Based on work from #32019
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld

tcitworld commented Mar 13, 2023

Copy link
Copy Markdown
Member

Closing here in favor of #37193

@tcitworldtcitworld mentioned this pull request Mar 13, 2023
Open
17 tasks
tcitworld pushed a commit that referenced this pull request May 2, 2023
@CarlSchwan@tcitworld
Introduce user id assigned typed events for LDAP usage
a047c14
Based on work from #32019
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld pushed a commit that referenced this pull request May 2, 2023
@CarlSchwan@tcitworld
Introduce user id assigned typed events for LDAP usage
ac0c201
Based on work from #32019
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@skjnldsv
skjnldsv deleted the cleanup/event/admin_audit branch March 14, 2024 07:46
come-nc pushed a commit that referenced this pull request Sep 10, 2024
@CarlSchwan@come-nc
Introduce user id assigned typed events for LDAP usage
038d067
Based on work from #32019
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
come-nc pushed a commit that referenced this pull request Sep 10, 2024
@CarlSchwan@come-nc
feat(user_ldap): Introduce user id assigned typed events for LDAP usage
986a3d4
Based on work from #32019
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz requested changes
@come-nccome-nccome-nc approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@artongeartongeAwaiting requested review from artonge

Assignees

@come-nccome-nc

Labels

2. developingWork in progress

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

7 participants

@CarlSchwan@mrAceT@tcitworld@nickvergessen@blizzz@github-advanced-security@come-nc